[API Proposal]: `ArgumentException.ThrowIfNullOrEmpty` for collections and spans

[BarionLP]

Background and motivation

throwing if a collection or span is empty

API Proposal

namespace System;

public class ArgumentException : SystemException
{
        public static void ThrowIfNullOrEmpty<T>([NotNull] T? argument, [CallerArgumentExpression(nameof(argument))] string? paramName = null) where T : System.Collections.ICollection
        {
            ArgumentNullException.ThrowIfNull(argument, paramName);
            if (argument.Count == 0)
            {
                throw new ArgumentException("The value cannot be an empty collection.", paramName);
            }
        }
        public static void ThrowIfEmpty<T>(ReadOnlySpan<T> argument, [CallerArgumentExpression(nameof(argument))] string? paramName = null)
        {
            if (argument.IsEmpty)
            {
                throw new ArgumentException("The value cannot be an empty span.", paramName);
            }
        }
}

API Usage

List<string> values = [];
ArgumentException.ThrowIfNullOrEmpty(values);

Alternative Designs

could use static extension members to add this feature without changing ArgumentException

Risks

No response

[BarionLP]

https://github.com/BarionLP/dotnet-runtime/tree/throwifemptycollection

[huoyaoyuan]

See #86830

[dotnet-policy-service]

Tagging subscribers to this area: @dotnet/area-system-runtime
See info in area-owners.md if you want to be subscribed.

[BarionLP]

See #86830

sorry, i missed that.
i need to add that this is certainly not a rare scenario (at least for spans and immutable arrays)

[MihaZupan]

FWIW Helpers over collections do sound useful, patterns like this are getting more common:

runtime/src/libraries/System.Private.CoreLib/src/System/IO/TextWriter.CreateBroadcasting.cs

Lines 50 to 53 in fa1604a

	foreach (TextWriter writer in writers)
	{
	ArgumentNullException.ThrowIfNull(writer, nameof(writers));
	}