Creating the native http handler throws BadImageFormatException

[rolfbjarne]

In a meastro bump for dotnet/dotnet from last week this is happening in our tests:

System.BadImageFormatException: Invalid usage of UnsafeAccessorAttribute.
   at System.Net.Http.HttpClientHandler.<CreateNativeHandler>g__CallNative|124_0()
   at System.Net.Http.HttpClientHandler.CreateNativeHandler()
   at System.Net.Http.HttpClientHandler..ctor()
   at System.Net.Http.HttpClient..ctor()

I'm guessing it's because if this change: da80937 (CC @jkoritzinsky)

This is the code in question:

runtime/src/libraries/System.Net.Http/src/System/Net/Http/HttpClientHandler.AnyMobile.InvokeNativeHandler.cs

Lines 333 to 340 in 528b402

	private static HttpMessageHandler CreateNativeHandler()
	{
	return (HttpMessageHandler)CallNative();
	[UnsafeAccessor(UnsafeAccessorKind.StaticMethod, Name = "GetHttpMessageHandler")]
	[return: UnsafeAccessorType(NativeHandlerType)]
	static extern object CallNative();
	}

I think maybe the CallNative method should be this instead?

static extern HttpMessageHandler CallNative([UnsafeAccessorType(NativeHandlerType)] object type);

[jonathanpeppers]

Yes, I'm seeing similar on Android:

• [main] Update dependencies from dotnet/dotnet android#10202

System.BadImageFormatException : Invalid usage of UnsafeAccessorAttribute.

Stack trace
   at System.Net.Http.HttpClientHandler.CreateNativeHandler()
   at System.Net.Http.HttpClientHandler..ctor()
   at Xamarin.Android.Net.AndroidClientHandler..ctor()
   at Xamarin.Android.NetTests.AndroidClientHandlerIntegrationTests.CreateHandler()
   at Xamarin.Android.NetTests.HttpClientIntegrationTestBase.DisallowAutoRedirect()
   at System.Reflection.MethodBaseInvoker.InterpretedInvoke_Method(Object obj, IntPtr* args)
   at System.Reflection.MethodBaseInvoker.InvokeWithNoArgs(Object , BindingFlags )

[dotnet-policy-service]

Tagging subscribers to this area: @dotnet/ncl
See info in area-owners.md if you want to be subscribed.

[lewing]

does your build include #116646 ?

[rolfbjarne]

does your build include #116646 ?

Looks like it does.

It has this code:

https://github.com/dotnet/dotnet/blob/be8cb623e031f933b5b62e82d37094b4981dce30/src/runtime/src/libraries/System.ComponentModel.TypeConverter/src/System/ComponentModel/TypeDescriptor.cs#L3068-L3071

which is the same from that PR:

https://github.com/dotnet/runtime/pull/116646/files