FinalizeObject event sends a BulkType event for every finalized object

[davmason]

Description

When the runtime emits the FinalizeObject ETW event, it always emits the BulkType event for the type being finalized. There may be thousands of finalized objects in a trace, and therefore thousands of unnecessary events.

Configuration

All versions of .net core

Regression?

Not a regression, this appears to be the behavior all the way back to desktop.

Other information

This code logs the type with kTypeBehaviorAlwaysLog

runtime/src/coreclr/src/vm/eventtrace.cpp

Lines 2528 to 2535 in 3ff193b

	ETW::TypeSystemLog::LogTypeAndParametersIfNecessary(
	NULL, // Not batching this type with others
	(TADDR) pMT,
	// Don't spend the time entering the lock and checking the hash table to see
	// if we've already logged the type; just log it (if type events are enabled).
	ETW::TypeSystemLog::kTypeLogBehaviorAlwaysLog
	);

[tommcdon]

Should we do this work as part of #45518?

[davmason]

We could, but I don't think this needs immediate attention.

It's not ideal that we repeatedly fire the same type event, but it has been this way since desktop and nobody is complaining. @Maoni0 asked why there were so many type events in a trace, and my investigation lead to creating this issue to capture the knowledge, but I don't think it's blocking anyone.

If someone has time to fix it or is touching nearby code it should be relatively simple, but it's relatively low priority.

[dotnet-policy-service]

Due to lack of recent activity, this issue has been marked as a candidate for backlog cleanup. It will be closed if no further activity occurs within 14 more days. Any new comment (by anyone, not necessarily the author) will undo this process.

This process is part of our issue cleanup automation.

[dotnet-policy-service]

This issue will now be closed since it had been marked no-recent-activity but received no further activity in the past 14 days. It is still possible to reopen or comment on the issue, but please note that the issue will be locked if it remains inactive for another 30 days.