Length calculation in objwriter looks suspicious

[agocke]

The value being written here is Len + 1, but the spec seems to imply that it should be just Len, similar to the issue in dotnet/llvm-project#317

https://github.com/dotnet/llvm-project/blob/5a92ffdc33b2acdf60e2d2ca5542990fa2148bfb/llvm/tools/objwriter/debugInfo/dwarf/dwarfGen.cpp#L455

This should be reviewed and verified.

Tagging subscribers to this area: @agocke, @MichalStrehovsky, @jkotas
See info in area-owners.md if you want to be subscribed.

Issue Details

---

The value being written here is Len + 1, but the spec seems to imply that it should be just Len, similar to the issue in dotnet/llvm-project#317

https://github.com/dotnet/llvm-project/blob/5a92ffdc33b2acdf60e2d2ca5542990fa2148bfb/llvm/tools/objwriter/debugInfo/dwarf/dwarfGen.cpp#L455

This should be reviewed and verified.

Author:	agocke
Assignees:	-
Labels:	area-NativeAOT-coreclr
Milestone:	8.0.0

[jkotas]

The managed DwarfInfoWriter does not have this issue:

runtime/src/coreclr/tools/aot/ILCompiler.Compiler/Compiler/ObjectWriter/Dwarf/DwarfInfoWriter.cs

Line 151 in d643f64

WriteULEB128((uint)_expressionBufferWriter.WrittenCount);