-
Notifications
You must be signed in to change notification settings - Fork 5.1k
Implement IUtf8SpanParsable
on Guid
#105654
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Note regarding the
|
1 similar comment
Note regarding the
|
@dotnet-policy-service agree |
src/libraries/System.Runtime/tests/System.Runtime.Tests/System/GuidTests.cs
Show resolved
Hide resolved
Tagging subscribers to this area: @dotnet/area-system-runtime |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Other than my comments/questions, LGTM. Thanks.
58f51af
to
81820ce
Compare
Just saw the updates, sorry for not responding quicker. Glad to see this merged! |
Part of #81500
API Proposal: #105653
This implements
IUtf8SpanParsable
onGuid
by making the core of the parsing logic generic onTChar : IUtfChar<TChar>
. A small amount of it is duplicated, with a version forchar
andbyte
, because doing so prevented a performance regression forchar
parsing.In addition, it adds a Utf8
Parse
andTryParse
without the unusedIFormatProvider
parameter, to match howISpanParsable
was implemented. I did not add Utf8 overloads forParseExact
, but that can be discussed in the linked API proposal.