Provide more info on the failing CustomAttributeProvider #110230
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jtschuster
added
the
area-Tools-ILLink
dotnet-policy-service
bot
added
the
linkable-framework
|
Tagging subscribers to this area: @dotnet/illink |
This was referenced Nov 27, 2024
stephentoub
reviewed
May 29, 2025
| _ => src.ToString () | ||
| }; | ||
|
|
||
| yield return string.Join (Environment.NewLine, $"Custom attributes on `{name}` are not matching:", missing, extra); |
There was a problem hiding this comment.
Nit: this still has backticks around the "name", so it's going to end up with messages like:
Custom attributes on `return type of `method`` are not matching:
stephentoub
approved these changes
May 29, 2025
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In testing #110229 I had trouble finding which CustomAttributeProvider was failing, so this PR adds more info about which provider is causing the test to fail.