Refactor Sequential/Explicit layout to happen in the same phase where we do Auto layout #113454
Conversation
… we do auto layout.
|
Tagging subscribers to this area: @mangod9 |
There was a problem hiding this comment.
Copilot reviewed 2 out of 12 changed files in this pull request and generated no comments.
Files not reviewed (10)
- src/coreclr/vm/class.cpp: Language not supported
- src/coreclr/vm/class.h: Language not supported
- src/coreclr/vm/classcompat.h: Language not supported
- src/coreclr/vm/fieldmarshaler.cpp: Language not supported
- src/coreclr/vm/fieldmarshaler.h: Language not supported
- src/coreclr/vm/jitinterface.cpp: Language not supported
- src/coreclr/vm/method.hpp: Language not supported
- src/coreclr/vm/methodtable.cpp: Language not supported
- src/coreclr/vm/methodtable.h: Language not supported
- src/coreclr/vm/methodtablebuilder.h: Language not supported
| /// @brief Read the offsets for a type's fields from metadata for explicit layout. | ||
| /// @param pModule The module containing the type. | ||
| /// @param cl The metadata token of the type. | ||
| /// @param pFieldInfoArray The information about the instance fields of the type. | ||
| /// @param cInstanceFields The numer of instance fields in the type. | ||
| /// @param parentSize The size of the parent type's layout. | ||
| /// @return The end of the last field in this layout |
There was a problem hiding this comment.
Is this doxygen? Do we have any other comments like this in runtime?
There was a problem hiding this comment.
Yeah this is the doxygen format. Got auto-inserted and was useful for setting things up. I see usages in Mono and the repo minipal, but not in coreclr. I can remove them if you want
|
/azp run runtime-coreclr crossgen2 outerloop |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
The only failure is an existing issue in the crossgen2 outerloop pipeline. We've now validated the new implementation in CoreCLR matches crossgen2 for all types in the BCL and in the runtime test tree. |
…form that can have an 8-byte alignment requirement
|
/ba-g host failure unrelated |
… we do Auto layout (#113454)
This will make it easier to implement #100896