Don't include LICENSE.TXT in nuget packages #115518
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Runtime nuget packages already define a PackageLicenseExpression=MIT There's no need to also bundle the LICENSE file into the packages as the nuspec correctly points to the license site.
There was a problem hiding this comment.
Pull Request Overview
This PR removes the LICENSE file from nuget packages as runtime packages now use PackageLicenseExpression=MIT, eliminating the need for a bundled LICENSE.TXT file.
- Removed the LICENSE file inclusion in the packaging item group for packable projects
- Aligns the build with Arcade validation requirements for package licensing
github-actions
bot
added
the
needs-area-label
akoeplinger
approved these changes
May 13, 2025
ViktorHofer
added
area-Infrastructure
and removed
needs-area-label
|
Tagging subscribers to this area: @dotnet/runtime-infrastructure |
ViktorHofer
added a commit
to dotnet/dotnet
that referenced
this pull request
May 13, 2025
Very similar to dotnet/runtime#115518 Don't include the LICENSE file in the shared framework produced packages if those set a PackageLicenseExpression. As mentioned in the other issue, Arcade already validates that either the license expression or the license file is set.
This was referenced May 13, 2025
SimaTian
pushed a commit
that referenced
this pull request
May 27, 2025
Runtime nuget packages already define a PackageLicenseExpression=MIT There's no need to also bundle the LICENSE file into the packages as the nuspec correctly points to the license site.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Runtime nuget packages already define a PackageLicenseExpression=MIT
There's no need to also bundle the LICENSE file into the packages as the nuspec points to the license url.
And Arcade already validates that there's either a PackageLicenseExpression or PackageLicenseFile defined: https://github.com/dotnet/arcade/blob/6b63184d8ff276115846b232816ece935a26a22c/src/Microsoft.DotNet.Arcade.Sdk/tools/Workarounds.targets#L65C105-L65C129