[wasm][coreclr] Interpret everything on wasm #115788
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
needs-area-label
radekdoulik
added
area-CodeGen-coreclr
There was a problem hiding this comment.
Pull Request Overview
This PR ensures that on the WebAssembly (WASM) target, the runtime uses the interpreter exclusively and skips loading or invoking the JIT.
- Wraps JIT-loading calls in
#ifndef TARGET_WASMto disable JIT on WASM - Statically links interpreter startup and
getJitentry points for WASM incodeman.cpp - Defines
INTERP_APIfor symbol visibility and forces interpretation of all methods ineeinterp.cppwhen building for WASM
Reviewed Changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| src/coreclr/vm/jitinterface.cpp | Add TARGET_WASM guards to bypass JIT loading and runtime paths |
| src/coreclr/vm/codeman.cpp | Conditionally include interpreter headers and stub JIT startup/getJit |
| src/coreclr/interpreter/interpretershared.h | Define INTERP_API macro for cross-platform symbol visibility |
| src/coreclr/interpreter/eeinterp.cpp | Force doInterpret = true on WASM builds |
Comments suppressed due to low confidence (2)
src/coreclr/vm/jitinterface.cpp:13365
- The preprocessor directive
#elifwithout a condition is invalid here. Replace it with#elseor#elif !defined(TARGET_WASM)to properly handle the non-WASM branch.
#elif // !TARGET_WASM
src/coreclr/vm/codeman.cpp:1781
- This
#elifdirective is missing an expression and will not compile. Use#elseto cover the non-WASM case.
#elif
jakobbotsch
added
area-CodeGen-Interpreter-coreclr
and removed
area-CodeGen-coreclr
|
Tagging subscribers to this area: @BrzVlad, @janvorli, @kg |
Open
3 tasks
|
The armel build was broken in main too and was fixed with #115767 |
jkotas
reviewed
May 21, 2025
jkotas
reviewed
May 21, 2025
|
Could you please fix the merge conflicts? |
jkotas
reviewed
May 22, 2025
jkotas
reviewed
May 22, 2025
Do not try to setup the jit and use it, instead use the interpreter
Co-authored-by: Jan Kotas <jkotas@microsoft.com>
Co-authored-by: Jan Kotas <jkotas@microsoft.com>
radekdoulik
force-pushed
the
wasm-coreclr-use-interp-on-wasm
branch
from
d2c3c65 to
fc1f6b2
Compare
jkotas
reviewed
May 23, 2025
jkotas
reviewed
May 23, 2025
jkotas
reviewed
May 23, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Do not try to setup the jit and use it, instead use the interpreter