Re-revert "Make mutable generic collection interfaces implement read-only collection interfaces (#95830)"

[Sergio0694]

Completes #31001

This PR reverts #101644, which reverted #95830, and makes all built-in mutable collection/list/dictionary/set interfaces extend their relative counterparts, using DIMs (default interface method implementations) to implement them by default.

We have been working with the MSVC team, which is currently preparing a fix for this for C++/CLI, so that the change will not cause breaks in WPF applications. The fix will be ingested into a future MSVC update, and we're coordinating with them to ensure the timeline is aligned so it gets ingested in time for .NET 10, leaving enough time to validate things. In the meantime, we're opening this PR to merge the actual runtime/BCL changes earlier, so that we can get additional validation in other scenarios, and to have more time for the broader community to provide feedback as well.

cc. @richlander @tannergooding @stephentoub @jkotas @AaronRobinsonMSFT

[Copilot]

Pull Request Overview

This PR re-applies the change that makes all mutable collection/list/dictionary/set interfaces extend their read-only counterparts via default interface method implementations. It updates LINQ fast-paths, core runtime dispatch, dynamic and collection classes, and adapts existing tests to exercise the new read-only APIs.

• LINQ: Switch IList<T>/ICollection<T> checks to IReadOnlyList<T>/IReadOnlyCollection<T> in performance-sensitive methods.
• Core and runtime: Simplify array generic interface method binding and add IReadOnlyDictionary to ExpandoObject.
• Tests: Introduce CollectionAsserts helpers and wrap read-only interface assertions under #if !NETFRAMEWORK.

Reviewed Changes

Copilot reviewed 37 out of 37 changed files in this pull request and generated 3 comments.

File	Description
src/libraries/System.Linq/src/System/Linq/*.cs	Replace mutable interface checks with their read-only counterparts.
src/libraries/System.Linq.Expressions/src/System/Dynamic/ExpandoObject.cs	Add IReadOnlyDictionary<string, object?> implementation and members.
src/libraries/Common/tests/System/Collections/CollectionAsserts.cs	New test helpers to assert both mutable and read-only interface behavior.
src/coreclr/vm/array.cpp	Simplify generic array interface dispatch; remove slot-based lookup.

Comments suppressed due to low confidence (1)

src/libraries/Common/tests/System/Collections/CollectionAsserts.cs:13

• [nitpick] Many helper methods repeat the pattern of asserting on both mutable and read-only interfaces; consider consolidating the #if !NETFRAMEWORK block into a single helper or method attribute to reduce duplication.

internal static class CollectionAsserts

[jkotas]

In the meantime, we're opening this PR to merge the actual runtime/BCL changes earlier

I do not see how we can merge this before the MSVC fixes are released.

[tannergooding]

This was approved in tactics today. The C++/CLI issue that previously blocked this was resolved and will be available in a VS release by the time .NET 10 releases.

In the interim, a workaround for dotnet/wpf is required and is here: https://github.com/dotnet/wpf/tree/cppcli-workaround. It will need to be taken as part of the PR that pulls in the newer version of dotnet/runtime containing this change and can be reverted once the CI machines are updated to include the version of C++/CLI with the relevant fix.

A breaking-change doc still needs to be created and this needs to be included in the .NET 10 Preview 6 Release notes.

[dotnet-policy-service]

Added needs-breaking-change-doc-created label because this PR has the breaking-change label.

When you commit this breaking change:

1. Create and link to this PR and the issue a matching issue in the dotnet/docs repo using the breaking change documentation template, then remove this needs-breaking-change-doc-created label.
2. Ask a committer to mail the .NET Breaking Change Notification DL.

Tagging @dotnet/compat for awareness of the breaking change.

[tannergooding]

The breaking change doc issue is logged here: dotnet/docs#46551

We will need to ensure this is included in the .NET 10 Preview 6 release notes and blog post.