Do not shortcut CompilerComparer
#115807
Merged
Do not shortcut CompilerComparer
#115807
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In rt-sz (https://github.com/MichalStrehovsky/rt-sz/actions/runs/15128663241/job/42525897839) I ran into following exception: ``` System.AggregateException: One or more errors occurred. (Specified cast is not valid.) ---> System.InvalidCastException: Specified cast is not valid. at ILCompiler.DependencyAnalysis.RuntimeImportMethodNode.CompareToImpl(ISortableNode, CompilerComparer) + 0x3c ``` I am not actually able to repro this locally, but this seems to be the only way how this could happen (we're trying to compare two nodes that are not of the same type - `CompilerComparer` will handle that case; `CompareToImpl` will not).
There was a problem hiding this comment.
Pull Request Overview
This PR addresses a runtime exception in the comparison logic between nodes by replacing the direct call to CompareToImpl with a call to CompilerComparer.Compare instead.
- Replace direct node comparison calls with CompilerComparer.Compare to avoid invalid cast exceptions.
- Applies the change consistently across TentativeMethodNode.cs and AddressTakenMethodNode.cs.
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| src/coreclr/tools/aot/ILCompiler.Compiler/Compiler/DependencyAnalysis/TentativeMethodNode.cs | Changed node comparison implementation to delegate to CompilerComparer. |
| src/coreclr/tools/aot/ILCompiler.Compiler/Compiler/DependencyAnalysis/AddressTakenMethodNode.cs | Updated node comparison to use CompilerComparer for consistent type handling. |
Comments suppressed due to low confidence (2)
src/coreclr/tools/aot/ILCompiler.Compiler/Compiler/DependencyAnalysis/TentativeMethodNode.cs:68
- Replacing the direct call to _methodNode.CompareToImpl with comparer.Compare prevents invalid cast exceptions when comparing nodes of different types. Please verify that this change maintains the expected ordering across all node comparisons.
return comparer.Compare(_methodNode, ((TentativeMethodNode)other)._methodNode);
src/coreclr/tools/aot/ILCompiler.Compiler/Compiler/DependencyAnalysis/AddressTakenMethodNode.cs:62
- Using CompilerComparer.Compare here correctly resolves the invalid cast issue by handling type differences in node comparisons. Ensure that the new comparison logic meets all sorting requirements for AddressTakenMethodNode.
return comparer.Compare(_methodNode, ((AddressTakenMethodNode)other)._methodNode);
jkotas
approved these changes
May 20, 2025
Open
3 tasks
|
/ba-g timeouts |
SimaTian
pushed a commit
that referenced
this pull request
May 27, 2025
In rt-sz (https://github.com/MichalStrehovsky/rt-sz/actions/runs/15128663241/job/42525897839) I ran into following exception: ``` System.AggregateException: One or more errors occurred. (Specified cast is not valid.) ---> System.InvalidCastException: Specified cast is not valid. at ILCompiler.DependencyAnalysis.RuntimeImportMethodNode.CompareToImpl(ISortableNode, CompilerComparer) + 0x3c ``` I am not actually able to repro this locally, but this seems to be the only way how this could happen (we're trying to compare two nodes that are not of the same type - `CompilerComparer` will handle that case; `CompareToImpl` will not).
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In rt-sz (https://github.com/MichalStrehovsky/rt-sz/actions/runs/15128663241/job/42525897839) I ran into following exception:
I am not actually able to repro this locally, but this seems to be the only way how this could happen (we're trying to compare two nodes that are not of the same type -
CompilerComparerwill handle that case;CompareToImplwill not).