BypassReadyToRun when initializing ProbabilisticMap #115811
Merged
+7
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR ensures that the SetCharBit and IsCharBitSet methods in ProbabilisticMap bypass ReadyToRun compilation so that intrinsic support checks remain consistent between initialization and search.
- Expanded comment explaining why these methods must bypass R2R
- Applied
[BypassReadyToRun]to bothSetCharBitandIsCharBitSet
Comments suppressed due to low confidence (1)
src/libraries/System.Private.CoreLib/src/System/SearchValues/ProbabilisticMap.cs:79
- Consider adding unit tests that simulate both intrinsic-supported and fallback code paths for SetCharBit and IsCharBitSet to verify behavior remains identical under tiered compilation and that the bypass attribute doesn't introduce inconsistencies.
[BypassReadyToRun]
davidwrighton
approved these changes
Jun 14, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #89979
The set of supported intrinsics impacts how the structure is laid out in memory, so the init logic must never disagree with the search logic.