Add targeted regression test for #115442 #115817
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Tagging subscribers to this area: @agocke, @MichalStrehovsky, @jkotas |
There was a problem hiding this comment.
Pull Request Overview
Adds a targeted regression test for issue #115442.
- Registers
Test115442Regressionin the SmokeTests runner - Defines a
TypeBuilder<T1, T2>struct and aRunmethod to invoke its genericAdd<T3>method via reflection
Comment on lines
+3689
to
+3692
| class Test115442Regression | ||
| { | ||
| public readonly struct TypeBuilder<T1, T2> | ||
| { |
There was a problem hiding this comment.
Consider adding a comment describing the purpose of this regression test (e.g., verifying reflection invocation on generic methods with tuple-based type parameters) to improve maintainability and future clarity.
Suggested change
| class Test115442Regression | |
| { | |
| public readonly struct TypeBuilder<T1, T2> | |
| { | |
| // Regression test for issue 115442 | |
| // Verifies that reflection invocation works correctly on a generic method | |
| // with tuple-based type parameters. | |
| class Test115442Regression | |
| { | |
| public readonly struct TypeBuilder<T1, T2> |
Copilot uses AI. Check for mistakes.
jkotas
approved these changes
May 21, 2025
SimaTian
pushed a commit
that referenced
this pull request
May 27, 2025
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #115442.