[browser] EP profiler - identify top frame, positive PID #115825
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pavelsavara
added
arch-wasm
pavelsavara
requested review from
lewing,
BrzVlad,
kotlarmilos,
steveisok,
vitek-karas and
lateralusX
as code owners
There was a problem hiding this comment.
Pull Request Overview
This PR addresses several profiler and event tracing issues by ensuring proper PID values and refining profiler call handling for improved stability and API consistency.
- Update WASM sample project instrumentation configuration
- Ensure interpreter frames correctly set the instruction pointer prior to profiler callbacks
- Update event tracing calls and diagnostics promises to resolve profiler-related issues
Reviewed Changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| src/mono/sample/wasm/browser-eventpipe/Wasm.Browser.EventPipe.Sample.csproj | Updated instrumentation configuration for WebAssembly profiling |
| src/mono/mono/mini/interp/interp.c | Modified profiler call blocks to set the instruction pointer correctly |
| src/mono/mono/eventpipe/ep-rt-mono-runtime-provider.c | Adjusted event writing to pass the correct thread context and updated context initialization |
| src/mono/browser/runtime/startup.ts | Updated PID calculation to produce a positive 31-bit integer |
| src/mono/browser/runtime/diagnostics/diagnostics-js.ts | Added resolution of onClosePromise after diagnostic client closure |
|
/backport to release/10.0-preview5 |
|
Started backporting to release/10.0-preview5: https://github.com/dotnet/runtime/actions/runs/15192146608 |
4 tasks
akoeplinger
approved these changes
May 22, 2025
pavelsavara
changed the title
SimaTian
pushed a commit
that referenced
this pull request
May 27, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
module <<?!?>>in perfView for methods on top of the stack