JIT: Copy BBF_ASYNC_RESUMPTION when splitting edges in LSRA
#115836
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Async resumption BBs are introduced late enough that we allow them to do some things that general BBs are not allowed to do. For example, they are allowed to jump into try regions at any point. This allowance is marked with the `BBF_ASYNC_RESUMPTION` flag. Propagate this flag from the source when edges are split by LSRA to allow the new block the same affordances.
github-actions
bot
added
the
area-CodeGen-coreclr
There was a problem hiding this comment.
Pull Request Overview
This PR ensures that the BBF_ASYNC_RESUMPTION flag is correctly propagated when splitting edges in LSRA, thereby allowing async resumption basic blocks to properly jump into try/handler regions. Key changes include:
- Replacing printf debug statements with JITDUMP in fgdiagnostic.cpp.
- Copying the BBF_ASYNC_RESUMPTION flag into the new block when splitting edges in fgbasic.cpp.
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| src/coreclr/jit/fgdiagnostic.cpp | Replaced printf with JITDUMP for consistency in diagnostic logging. |
| src/coreclr/jit/fgbasic.cpp | Propagates the BBF_ASYNC_RESUMPTION flag during edge splitting. |
Comments suppressed due to low confidence (1)
src/coreclr/jit/fgbasic.cpp:4973
- Verify that the CopyFlags call for BBF_ASYNC_RESUMPTION is additive and does not inadvertently override previously copied flags. If it overwrites flags, consider combining the flag copying into a single call to preserve all intended flag settings.
newBlock->CopyFlags(curr, BBF_ASYNC_RESUMPTION);
|
Tagging subscribers to this area: @JulieLeeMSFT, @jakobbotsch |
|
PTAL @dotnet/jit-contrib |
EgorBo
approved these changes
May 21, 2025
AndyAyersMS
approved these changes
May 21, 2025
I don't think so, but if so the fix here is inside |
SimaTian
pushed a commit
that referenced
this pull request
May 27, 2025
Async resumption BBs are introduced late enough that we allow them to do some things that general BBs are not allowed to do. For example, they are allowed to jump into try regions at any point. This allowance is marked with the `BBF_ASYNC_RESUMPTION` flag. Propagate this flag from the source when edges are split by LSRA to allow the new block the same affordances.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Async resumption BBs are introduced late enough that we allow them to do some things that general BBs are not allowed to do. For example, they are allowed to jump into try regions at any point. This allowance is marked with the
BBF_ASYNC_RESUMPTIONflag. Propagate this flag from the source when edges are split by LSRA to allow the new block the same affordances.Fix #115835