Use new TypeName methods in runtime tools #115857
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dotnet-policy-service
bot
added
the
linkable-framework
Co-authored-by: MichalStrehovsky <13110571+MichalStrehovsky@users.noreply.github.com>
Copilot
AI
changed the title
Copilot finished work on behalf of
MichalStrehovsky
May 22, 2025 04:41
src/coreclr/tools/Common/TypeSystem/Common/Utilities/CustomAttributeTypeNameParser.cs
Outdated
Show resolved
Hide resolved
src/coreclr/tools/Common/TypeSystem/Common/Utilities/CustomAttributeTypeNameParser.cs
Outdated
Show resolved
Hide resolved
…NameParser.cs Co-authored-by: MichalStrehovsky <13110571+MichalStrehovsky@users.noreply.github.com>
Copilot finished work on behalf of
MichalStrehovsky
May 22, 2025 04:52
|
You missed removing a reference to the now-deleted Common/src/System/Reflection/Metadata/TypeNameHelpers.cs file. There's a build break: |
Co-authored-by: MichalStrehovsky <13110571+MichalStrehovsky@users.noreply.github.com>
... Fixed in commit 5b7f26b by removing the reference to TypeNameHelpers.cs from ILVerification.projitems. Warning Firewall rules blocked me from connecting to one or more addressesI tried to connect to the following addresses, but was blocked by firewall rules:
If you need me to access, download, or install something from one of these locations, you can either:
|
Copilot finished work on behalf of
MichalStrehovsky
May 22, 2025 05:11
src/coreclr/tools/Common/TypeSystem/Common/Utilities/CustomAttributeTypeNameParser.cs
Show resolved
Hide resolved
Co-authored-by: MichalStrehovsky <13110571+MichalStrehovsky@users.noreply.github.com>
Copilot finished work on behalf of
MichalStrehovsky
May 22, 2025 05:58
|
LGTM. Cc @dotnet/ilc-contrib for review since I apparently cannot sigoff myself. |
jkotas
approved these changes
May 22, 2025
Open
3 tasks
|
/ba-g infrastructure timeout |
SimaTian
pushed a commit
that referenced
this pull request
May 27, 2025
Replace the usage of the TypeNameHelpers utility class with the newer TypeName class methods and properties in the runtime tools. Co-authored-by: MichalStrehovsky <13110571+MichalStrehovsky@users.noreply.github.com> Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR replaces the usage of the now-deprecated
TypeNameHelpersutility class with the newerTypeNameclass methods and properties in the runtime tools. The changes include:TypeNameHelpers.csfile fromsrc/libraries/Common/src/System/Reflection/MetadataILCompiler.TypeSystem.csprojILCompiler.Trimming.Tests.csprojILCompiler.Compiler.csprojMono.Linker.csprojTypeNameHelpers.UnescapewithTypeName.UnescapeTypeNameHelpers.Splittuple returns with direct access toTypeName.NamespaceandTypeName.NamepropertiesThe changes are minimal and focused only on the required updates. No functional changes were made, as the implementations in
TypeNameprovide identical functionality to what was inTypeNameHelpers.Fixes #112376.
Warning
Firewall rules blocked me from connecting to one or more addresses
I tried to connect to the following addresses, but was blocked by firewall rules:
pkgs.dev.azure.com/home/REDACTED/work/runtime/runtime/.dotnet/dotnet msbuild /m /nologo /clp:Summary /v:minimal /nr:true /warnaserror /p:TreatWarningsAsErrors=true /p:ContinuousIntegrationBuild=false /home/REDACTED/work/runtime/runtime/artifacts/toolset/restore.proj /t:__WriteToolsetLocation /clp:ErrorsOnly;NoSummary /p:__ToolsetLocationOutputFile=/home/REDACTED/work/runtime/runtime/artifacts/toolset/10.0.0-beta.25260.104.txt(dns block)./.dotnet/dotnet build src/coreclr/tools/aot/ILCompiler.TypeSystem/ILCompiler.TypeSystem.csproj(dns block)/home/REDACTED/work/_temp/ghcca-node/node/bin/node /home/REDACTED/work/_temp/copilot-developer-action-main/dist/index.js(dns block)If you need me to access, download, or install something from one of these locations, you can either:
💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.