Skip to content

Conversation

huoyaoyuan
Copy link
Member

Fix the build break introduced in #115408. Build passes on local WSL.

/cc @AaronRobinsonMSFT

@dotnet-policy-service dotnet-policy-service bot added the community-contribution Indicates that the PR has been added by a community member label May 22, 2025
@AaronRobinsonMSFT
Copy link
Member

I already applied a fix in #115858. We can take this one, but I don't see why we changed from hires to lowres. Is there a reason?

@huoyaoyuan
Copy link
Member Author

huoyaoyuan commented May 22, 2025

The original logic of GetHighPrecisionTimeStamp is ts.QuadPart / (performanceFrequency.QuadPart / 1000);, and performanceFrequency is "tick per second", so it's dividing "tick per ms" and getting a millisecond count. It matches the lowres contract which is a millisecond count. The assert message "The sleep function slept for %d ms when it should have slept for %d ms\n" also supports this.

@AaronRobinsonMSFT
Copy link
Member

/azp list

Copy link

CI/CD Pipelines for this repository:

@jkotas
Copy link
Member

jkotas commented May 22, 2025

/ba-g infrastructure timeout

@jkotas jkotas merged commit b4bd13d into dotnet:main May 22, 2025
94 of 97 checks passed
@huoyaoyuan huoyaoyuan deleted the minipal-time-fix branch May 22, 2025 16:35
SimaTian pushed a commit that referenced this pull request May 27, 2025
* Use minipal_lowres_ticks for paltests

* Delete unused GetHighPrecisionTimeStamp
@github-actions github-actions bot locked and limited conversation to collaborators Jun 22, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area-PAL-coreclr community-contribution Indicates that the PR has been added by a community member
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants