-
Notifications
You must be signed in to change notification settings - Fork 5.1k
Add a copilot prompt file for JIT-EE interface modifications #115889
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
@stephentoub @mrsharm @dotnet/jit-contrib opinions? |
Sounds cool, LGTM 🙂 |
Tagging subscribers to this area: @JulieLeeMSFT, @jakobbotsch |
Co-authored-by: Jakob Botsch Nielsen <Jakob.botsch.nielsen@gmail.com>
I would add "please" in a couple of places. Just in case.. |
Any hints where/study? 🙂 |
@jakobbotsch could you then approve it? 🙂 |
/ba-g "build analysis stuck" |
Adding new APIs to the JIT-EE interface is time-consuming and is difficult to automate: 15-16 files need to be updated with a complex (de)serialization logic in SPMI. So far, we’ve managed to automate generation for only 7 of those files; the rest still require manual edits. This prompt file (see Prompt Files feature) is designed to help with it. The typical workflow looks like this:
/add-new-jit-ee-api.prompt
(there should be suggestions) and hit enterIt is supposed to ask for the signature (e.g.
CORINFO_METHOD_HANDLE getHelperHandle(int helperId)
) and perform all the modifications (including thegen.sh
script).Alternatively, you can type the signature right away
/add-new-jit-ee-api.prompt CORINFO_METHOD_HANDLE getHelperHandle(int helperId)
It managed to successfully generate simple APIs for me (sometimes not from the first try). If it lands, I presume we can improve the prompt to handle more complex cases if it fails on them.