Skip to content

[release/10.0-preview5][browser] EP profiler - identify top frame, positive PID #115906

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

github-actions[bot]
Copy link
Contributor

@github-actions github-actions bot commented May 22, 2025

Backport of #115825 to release/10.0-preview5

Make sure we use a non-negative value when reporting the PID in the event source even though the PID concept does not apply here.

/cc @pavelsavara

Customer Impact

  • Customer reported
  • Found internally

See #115579

Regression

  • Yes
  • No

This is new feature in Net10 wasm runtime.

Testing

Manual testing.

Risk

Low. This will only impact new diagnostic scenario for WASM, which is broken without this fix.

@pavelsavara pavelsavara self-assigned this May 22, 2025
@pavelsavara pavelsavara added arch-wasm WebAssembly architecture area-Diagnostics-mono os-browser Browser variant of arch-wasm labels May 22, 2025
Copy link
Contributor

Tagging subscribers to 'arch-wasm': @lewing
See info in area-owners.md if you want to be subscribed.

@pavelsavara pavelsavara changed the title [release/10.0-preview5] [browser] EP profiler - identify top frame [release/10.0-preview5][browser] EP profiler - identify top frame, positive PID May 22, 2025
@lewing lewing added the Servicing-consider Issue for next servicing release review label May 22, 2025
@pavelsavara pavelsavara added this to the 10.0.0 milestone May 22, 2025
@leecow leecow added Servicing-approved Approved for servicing release and removed Servicing-consider Issue for next servicing release review labels May 22, 2025
@lewing lewing merged commit f0b32c1 into release/10.0-preview5 May 22, 2025
79 of 86 checks passed
@lewing lewing deleted the backport/pr-115825-to-release/10.0-preview5 branch May 22, 2025 20:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
arch-wasm WebAssembly architecture area-Diagnostics-mono os-browser Browser variant of arch-wasm Servicing-approved Approved for servicing release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants