add HttpMethod.Query #115934
Merged
add HttpMethod.Query #115934
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR adds support for the new HTTP method "QUERY" by introducing a corresponding static property in HttpMethod and updating the parsing logic.
- Added Query property to HttpMethod in both implementation and reference assemblies.
- Extended the Parse method to handle method strings starting with 'q' by returning Query.
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| src/libraries/System.Net.Http/src/System/Net/Http/HttpMethod.cs | New Query property added and Parse method updated to support "QUERY". |
| src/libraries/System.Net.Http/ref/System.Net.Http.cs | Public API updated to include the Query property. |
dotnet-policy-service
bot
added
the
community-contribution
|
Tagging subscribers to this area: @dotnet/ncl |
Open
3 tasks
WeihanLi
force-pushed
the
http-method-query
branch
from
d020142 to
42b3af3
Compare
This was referenced May 24, 2025
MihaZupan
approved these changes
May 26, 2025
There was a problem hiding this comment.
Thanks.
Can you please also add the new method in tests?
https://github.com/dotnet/runtime/blob/main/src/libraries/System.Net.Http/tests/FunctionalTests/HttpMethodTest.cs
WeihanLi
force-pushed
the
http-method-query
branch
from
d1b7139 to
a67de51
Compare
MihaZupan
approved these changes
May 26, 2025
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #114489