Skip to content

Disable Android tests in default CI set for now #115956

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 24, 2025
Merged

Disable Android tests in default CI set for now #115956

merged 1 commit into from
May 24, 2025

Conversation

jkotas
Copy link
Member

@jkotas jkotas commented May 24, 2025

Workaround for #115955

@jkotas jkotas requested review from Copilot, kotlarmilos and hoyosjs and removed request for Copilot May 24, 2025 03:24
@github-actions github-actions bot added the needs-area-label An area label is needed to ensure this gets routed to the appropriate area owners label May 24, 2025
Copilot
Copilot AI reviewed May 24, 2025
View reviewed changes
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR provides a workaround for issue #115955 by disabling Android tests in the default CI set.

  • Updates the build arguments in the runtime.yml pipeline configuration.
  • Disables test assemblies by changing the parameter from "/p:RunSmokeTestsOnly=true" to "/p:TestAssemblies=false".

eng/pipelines/runtime.yml
@@ -956,7 +956,7 @@ extends:
jobParameters:
testGroup: innerloop
nameSuffix: AllSubsets_CoreCLR
buildArgs: -s clr.runtime+clr.alljits+clr.corelib+clr.nativecorelib+clr.tools+clr.packages+libs+libs.tests+host+packs -c $(_BuildConfig) /p:ArchiveTests=true /p:RunSmokeTestsOnly=true
buildArgs: -s clr.runtime+clr.alljits+clr.corelib+clr.nativecorelib+clr.tools+clr.packages+libs+libs.tests+host+packs -c $(_BuildConfig) /p:ArchiveTests=true /p:TestAssemblies=false
Copy link
Preview

Copilot AI May 24, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Consider adding an inline comment explaining the rationale for disabling test assemblies in the CI pipeline to support future maintainers in understanding this workaround.

Copilot uses AI. Check for mistakes.

@jkotas jkotas mentioned this pull request May 24, 2025
Closed
@jkotas jkotas added os-android and removed needs-area-label An area label is needed to ensure this gets routed to the appropriate area owners labels May 24, 2025
@dotnet-policy-service Dotnet Policy Service
Copy link
Contributor

Tagging subscribers to this area: @hoyosjs
See info in area-owners.md if you want to be subscribed.

hoyosjs
hoyosjs reviewed May 24, 2025
View reviewed changes
eng/pipelines/runtime.yml
@@ -956,7 +956,7 @@ extends:
jobParameters:
testGroup: innerloop
nameSuffix: AllSubsets_CoreCLR
buildArgs: -s clr.runtime+clr.alljits+clr.corelib+clr.nativecorelib+clr.tools+clr.packages+libs+libs.tests+host+packs -c $(_BuildConfig) /p:ArchiveTests=true /p:RunSmokeTestsOnly=true
buildArgs: -s clr.runtime+clr.alljits+clr.corelib+clr.nativecorelib+clr.tools+clr.packages+libs+libs.tests+host+packs -c $(_BuildConfig) /p:ArchiveTests=true /p:TestAssemblies=false
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So disable the project reference to library tests? if this correctly passes Helix in the next step- no issue. Just unclear what we are sending at that point?

Copy link
Member Author

@jkotas jkotas May 24, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is revert of this line https://github.com/dotnet/runtime/pull/114148/files#diff-e2e027b9777fc35f4a8243db97ce50f7dac99b3cee9465c5325d283c34d2d872R959 from the PR that enabled Android tests a few days ago. I believe that this is only going to validate the build now.

@hoyosjs
Copy link
Member

hoyosjs commented May 24, 2025 

[
  {
    "DetailsUrl": "https://helix.dot.net/api/jobs/b0767735-80e0-45cb-b935-537dece0b48f/workitems/Android.Device_Emulator.JIT.Static.Test?api-version=2019-06-17",
    "Job": "b0767735-80e0-45cb-b935-537dece0b48f",
    "Name": "Android.Device_Emulator.JIT.Static.Test",
    "State": "Finished"
  },
  {
    "DetailsUrl": "https://helix.dot.net/api/jobs/b0767735-80e0-45cb-b935-537dece0b48f/workitems/Android.Device_Emulator.JIT.Test?api-version=2019-06-17",
    "Job": "b0767735-80e0-45cb-b935-537dece0b48f",
    "Name": "Android.Device_Emulator.JIT.Test",
    "State": "Finished"
  },
  {
    "DetailsUrl": "https://helix.dot.net/api/jobs/b0767735-80e0-45cb-b935-537dece0b48f/workitems/HelixController%20Work%20Queueing?api-version=2019-06-17",
    "Job": "b0767735-80e0-45cb-b935-537dece0b48f",
    "Name": "HelixController Work Queueing",
    "State": "Finished"
  }
]

Couple things ran - it's quick as far as I can tell though.

@build-analysis build-analysis bot mentioned this pull request May 24, 2025
Open
3 tasks
@jkotas
Copy link
Member Author

jkotas commented May 24, 2025

/ba-g infrastructure failure with no log

@jkotas jkotas merged commit d896e85 into dotnet:main May 24, 2025
150 of 153 checks passed
@jkotas jkotas deleted the workaround-115955 branch May 25, 2025 06:54
@jkotas jkotas mentioned this pull request May 25, 2025
Merged
@github-actions github-actions bot locked and limited conversation to collaborators Jun 24, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

Copilot code review Copilot

@hoyosjs hoyosjs

@kotlarmilos kotlarmilos

Assignees

@jkotas jkotas

Labels
area-Infrastructure-coreclr os-android
Projects
Runtime Infra
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jkotas @hoyosjs