Skip to content

Record exception in HttpClient native instrumentation #115959

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 13 commits into from
May 30, 2025
Merged

Record exception in HttpClient native instrumentation #115959

merged 13 commits into from
May 30, 2025

Conversation

joegoldman2
Copy link
Contributor

Fixes #108050.

@dotnet-policy-service dotnet-policy-service bot added the community-contribution Indicates that the PR has been added by a community member label May 24, 2025
@dotnet-policy-service Dotnet Policy Service
Copy link
Contributor

Tagging subscribers to this area: @dotnet/ncl
See info in area-owners.md if you want to be subscribed.

@build-analysis build-analysis bot mentioned this pull request May 25, 2025
Open
3 tasks
@joegoldman2 joegoldman2 mentioned this pull request May 25, 2025
Closed
@build-analysis build-analysis bot mentioned this pull request May 25, 2025
Open
3 tasks
antonfirsov
antonfirsov approved these changes May 26, 2025
View reviewed changes
Copy link
Member

@antonfirsov antonfirsov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good as-is, thank you!

This was referenced May 27, 2025
Closed
Closed
Closed
Open
@build-analysis build-analysis bot mentioned this pull request May 28, 2025
Open
@joegoldman2 joegoldman2 requested a review from antonfirsov May 30, 2025 04:27
@antonfirsov antonfirsov merged commit d4ca2ce into dotnet:main May 30, 2025
86 checks passed
@antonfirsov
Copy link
Member

Thanks for the PR again @joegoldman2!

@joegoldman2 joegoldman2 deleted the record-exception branch May 30, 2025 14:59
@github-actions github-actions bot locked and limited conversation to collaborators Jun 30, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@antonfirsov antonfirsov

Assignees
No one assigned
Labels
area-System.Net.Http community-contribution Indicates that the PR has been added by a community member
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Exception event missing from activity in HttpClient native instrumentation
2 participants
@joegoldman2 @antonfirsov