JIT: Add a gtFindNodeInTree helper
#115975
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add a gtFindNodeInTree helper to find a node in a tree matching a predicate, and use it in a couple of places
github-actions
bot
added
the
area-CodeGen-coreclr
|
Tagging subscribers to this area: @JulieLeeMSFT, @jakobbotsch |
|
PTAL @dotnet/jit-contrib. No diffs, just adding a helper and replacing a few places to use it. |
There was a problem hiding this comment.
Pull Request Overview
Introduces a generic gtFindNodeInTree helper to replace several bespoke tree‐walking visitors for finding nodes by predicate.
- Adds the
gtFindNodeInTreetemplate incompiler.hppwith flags-based subtree filtering. - Refactors existing
gtTreeContains*and custom visitor usages to callgtFindNodeInTree. - Eliminates duplicated visitor classes from
gschecks.cpp,gentree.cpp, andfgopt.cpp.
Reviewed Changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| compiler.hpp | Added gtFindNodeInTree template declaration |
| gschecks.cpp | Replaced custom GenTreeVisitor with gtFindNodeInTree |
| gentree.cpp | Swapped out gtTreeContainsOper visitor for helper |
| fgopt.cpp | Replaced gtTreeContainsCall patterns with helper |
| compiler.h | Removed obsolete gtTreeContainsCall declaration, added helper declaration |
AndyAyersMS
approved these changes
May 27, 2025
|
/ba-g Timeout is #115955 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a gtFindNodeInTree helper to find a node in a tree matching a predicate, and use it in a couple of places