Cleanup some PAL items #115986
Merged
Cleanup some PAL items #115986
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR cleans up unused performance tracing infrastructure and macros from PAL, while standardizing path length macros across the codebase. Key changes include the removal of perftrace‐related code and tests, replacing instances of _MAX_PATH with MAX_PATH, and updating build configuration files accordingly.
Reviewed Changes
Copilot reviewed 31 out of 31 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| src/coreclr/pal/tests/palsuite/paltestlist.txt | Removed GetACP test entry. |
| src/coreclr/pal/tests/palsuite/locale_info/GetACP/test1/test1.cpp src/coreclr/pal/tests/palsuite/file_io/GetConsoleOutputCP/test1/GetConsoleOutputCP.cpp |
Removed obsolete test files. |
| src/coreclr/pal/tests/palsuite/file_io/SearchPathW/test1/SearchPathW.cpp | Replaced _MAX_PATH with MAX_PATH for buffer allocations. |
| src/coreclr/pal/tests/palsuite/common/palsuite.h, CMakeLists.txt, and other PAL files | Removed perftrace related code and macros, and updated references to use MAX_PATH consistently. |
| src/coreclr/md/compiler/regmeta_vm.cpp src/coreclr/ilasm/assembler.h src/coreclr/debug/di/module.cpp |
Updated inline string buffer sizes from _MAX_PATH to MAX_PATH. |
|
Tagging subscribers to this area: @mangod9 |
jkotas
reviewed
May 26, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove perftrace infrastucture from PAL
Remove some unused/unuseful macros