JIT: Don't allow broadcast lowering to remove cast from decomposed long #116002
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #115202
I was unable to create a minimal repro for this, but using the latest SPMI context from #115202 (comment), I found the cause.
The problematic IR starts out as:
This
Vector256.Create
is lowered toAvx2.BroadcastScalarToVector256 <- Vector256.CreateScalarUnsafe <- CAST(int <- long)
.Then the containment check for broadcast, which looks for that specific pattern, is eating both the
CreateScalarUnsafe
and theGT_CAST
.Resulting in an uncontained
GT_LONG
:In this case, the cast should have been preserved, and it should contain the
GT_LONG
.Correct IR after lowering: