fix json source generator serialize when writing #116004
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dotnet-policy-service
bot
added
the
community-contribution
|
Tagging subscribers to this area: @dotnet/area-system-text-json, @gregsdennis |
remove required modifier
There was a problem hiding this comment.
Pull Request Overview
This PR fixes serialization behavior in the source generator so that properties marked with JsonIgnoreCondition.WhenWriting are correctly omitted, and adds corresponding tests.
- Added
SerializedValueCheckType.Ignoreenum value and mapping forWhenWriting - Updated emitter to handle the new ignore case in fast-path code
- Introduced two tests (
SerializeIgnoreWhenWritingTestandSerializeIgnoreWhenReadingTest) and theIgnoreWhenReadingWritingPersontype
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| JsonSerializerContextTests.cs | Added new tests and the IgnoreWhenReadingWritingPerson type |
| JsonSourceGenerator.Emitter.cs | Introduced Ignore enum case, mapped WhenWriting, and stubbed fast-path logic for skipping properties |
...System.Text.Json/tests/System.Text.Json.SourceGeneration.Tests/JsonSerializerContextTests.cs
Outdated
Show resolved
Hide resolved
removing the serializer options
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #116003