[RISC-V] Simplifying the loop generated in genZeroInitFrameUsingBlockInit #116011

sirntar · 2025-05-27T13:33:47Z

This PR is a resubmission of #114003 after fixing some overflow problems. I decided to drop jump encoding changes for this PR to avoid mixing two separate problems (I will resubmit the second part in the future).

As I mentioned in #114003 , a partial unrolling of the loop (and removing rCnt) results in a small performance gain (1.4% on average for coreclr tests and about 0.5% for corefx tests).

Part of #84834, cc @dotnet/samsung

risc-vv · 2025-06-02T06:06:00Z

RISC-V Release-CLR-QEMU: 9080 / 9110 (99.67%)

=======================
      passed: 9080
      failed: 2
     skipped: 599
      killed: 28
------------------------
 TOTAL tests: 9709
VIRTUAL time: 35h 16min 23s 632ms
   REAL time: 36min 1s 177ms
=======================

report.xml, report.md, failures.xml, testclr_details.tar.zst

RISC-V Release-CLR-VF2: 9081 / 9111 (99.67%)

=======================
      passed: 9081
      failed: 2
     skipped: 599
      killed: 28
------------------------
 TOTAL tests: 9710
VIRTUAL time: 10h 23min 58s 761ms
   REAL time: 42min 29s 516ms
=======================

report.xml, report.md, failures.xml, testclr_details.tar.zst

RISC-V Release-FX-QEMU: 282794 / 283851 (99.63%)

=======================
      passed: 282794
      failed: 1052
     skipped: 38
      killed: 5
------------------------
 TOTAL tests: 283889
VIRTUAL time: 29h 2min 14s 258ms
   REAL time: 1h 11min 53s 133ms
=======================

report.xml, report.md, failures.xml, testclr_details.tar.zst

RISC-V Release-FX-VF2: 306368 / 308091 (99.44%)

=======================
      passed: 306368
      failed: 1713
     skipped: 38
      killed: 10
------------------------
 TOTAL tests: 308129
VIRTUAL time: 20h 13min 55s 171ms
   REAL time: 2h 6min 43s 925ms
=======================

report.xml, report.md, failures.xml, testclr_details.tar.zst

Build information and commands

GIT: c992ec03ad49bdb9d09214cb469feed4c5052967
CI: 8d15504ae1358a01693a7c50a10ed6536bf11989
REPO: dotnet/runtime
BRANCH: main
CONFIG: Release
LIB_CONFIG: Release

risc-vv · 2025-06-02T06:50:59Z

RISC-V Release-CLR-QEMU: 9080 / 9110 (99.67%)

=======================
      passed: 9080
      failed: 2
     skipped: 599
      killed: 28
------------------------
 TOTAL tests: 9709
VIRTUAL time: 35h 29min 54s 442ms
   REAL time: 36min 16s 21ms
=======================

report.xml, report.md, failures.xml, testclr_details.tar.zst

RISC-V Release-FX-QEMU: 283157 / 284218 (99.63%)

=======================
      passed: 283157
      failed: 1055
     skipped: 38
      killed: 6
------------------------
 TOTAL tests: 284256
VIRTUAL time: 29h 27min 49s 377ms
   REAL time: 1h 11min 12s 832ms
=======================

report.xml, report.md, failures.xml, testclr_details.tar.zst

RISC-V Release-CLR-VF2: 9081 / 9111 (99.67%)

=======================
      passed: 9081
      failed: 2
     skipped: 599
      killed: 28
------------------------
 TOTAL tests: 9710
VIRTUAL time: 10h 34min 19s 400ms
   REAL time: 43min 14s 532ms
=======================

report.xml, report.md, failures.xml, testclr_details.tar.zst

RISC-V Release-FX-VF2: 299180 / 300955 (99.41%)

=======================
      passed: 299180
      failed: 1766
     skipped: 38
      killed: 9
------------------------
 TOTAL tests: 300993
VIRTUAL time: 19h 25min 25s 188ms
   REAL time: 2h 9min 28s 263ms
=======================

report.xml, report.md, failures.xml, testclr_details.tar.zst

Build information and commands

GIT: 54a6a3dedf31d1da53c7adb1f09073080b322fb2
CI: 8d15504ae1358a01693a7c50a10ed6536bf11989
REPO: dotnet/runtime
BRANCH: main
CONFIG: Release
LIB_CONFIG: Release

src/coreclr/jit/codegenriscv64.cpp

risc-vv · 2025-06-02T14:06:17Z

RISC-V Release-CLR-QEMU: 9080 / 9110 (99.67%)

=======================
      passed: 9080
      failed: 2
     skipped: 599
      killed: 28
------------------------
 TOTAL tests: 9709
VIRTUAL time: 35h 15min 4s 45ms
   REAL time: 36min 3s 8ms
=======================

report.xml, report.md, failures.xml, testclr_details.tar.zst

RISC-V Release-FX-QEMU: 243197 / 244306 (99.55%)

=======================
      passed: 243197
      failed: 1102
     skipped: 38
      killed: 7
------------------------
 TOTAL tests: 244344
VIRTUAL time: 29h 45min 29s 740ms
   REAL time: 1h 12min 0s 357ms
=======================

report.xml, report.md, failures.xml, testclr_details.tar.zst

RISC-V Release-CLR-VF2: 9081 / 9111 (99.67%)

=======================
      passed: 9081
      failed: 2
     skipped: 599
      killed: 28
------------------------
 TOTAL tests: 9710
VIRTUAL time: 10h 36min 49s 257ms
   REAL time: 43min 19s 164ms
=======================

report.xml, report.md, failures.xml, testclr_details.tar.zst

RISC-V Release-FX-VF2: 298732 / 300460 (99.42%)

=======================
      passed: 298732
      failed: 1717
     skipped: 38
      killed: 11
------------------------
 TOTAL tests: 300498
VIRTUAL time: 20h 0min 38s 824ms
   REAL time: 2h 8min 5s 168ms
=======================

report.xml, report.md, failures.xml, testclr_details.tar.zst

Build information and commands

GIT: f4e089d795eed3e7e58fbbe048bb7193e20ea0c4
CI: 8d15504ae1358a01693a7c50a10ed6536bf11989
REPO: dotnet/runtime
BRANCH: main
CONFIG: Release
LIB_CONFIG: Release

risc-vv · 2025-06-03T09:36:05Z

RISC-V Release-CLR-QEMU: 9080 / 9110 (99.67%)

=======================
      passed: 9080
      failed: 2
     skipped: 599
      killed: 28
------------------------
 TOTAL tests: 9709
VIRTUAL time: 35h 27min 50s 272ms
   REAL time: 37min 7s 548ms
=======================

report.xml, report.md, failures.xml, testclr_details.tar.zst

RISC-V Release-CLR-VF2: 9080 / 9110 (99.67%)

=======================
      passed: 9080
      failed: 2
     skipped: 599
      killed: 28
------------------------
 TOTAL tests: 9709
VIRTUAL time: 10h 37min 5s 416ms
   REAL time: 43min 35s 766ms
=======================

report.xml, report.md, failures.xml, testclr_details.tar.zst

RISC-V Release-FX-QEMU: 280731 / 281810 (99.62%)

=======================
      passed: 280731
      failed: 1071
     skipped: 38
      killed: 8
------------------------
 TOTAL tests: 281848
VIRTUAL time: 29h 46min 27s 368ms
   REAL time: 1h 0min 9s 864ms
=======================

report.xml, report.md, failures.xml, testclr_details.tar.zst

RISC-V Release-FX-VF2: 307028 / 308798 (99.43%)

=======================
      passed: 307028
      failed: 1762
     skipped: 38
      killed: 8
------------------------
 TOTAL tests: 308836
VIRTUAL time: 20h 48min 16s 242ms
   REAL time: 2h 11min 4s 432ms
=======================

report.xml, report.md, failures.xml, testclr_details.tar.zst

Build information and commands

GIT: e3b9c7ce63e6ca0b5f39bc82779f8513856d02b1
CI: 8d15504ae1358a01693a7c50a10ed6536bf11989
REPO: dotnet/runtime
BRANCH: main
CONFIG: Release
LIB_CONFIG: Release

risc-vv · 2025-06-04T06:31:17Z

RISC-V Release-CLR-QEMU: 9080 / 9110 (99.67%)

=======================
      passed: 9080
      failed: 2
     skipped: 599
      killed: 28
------------------------
 TOTAL tests: 9709
VIRTUAL time: 35h 12min 28s 674ms
   REAL time: 35min 58s 846ms
=======================

report.xml, report.md, failures.xml, testclr_details.tar.zst

RISC-V Release-CLR-VF2: 9081 / 9111 (99.67%)

=======================
      passed: 9081
      failed: 2
     skipped: 599
      killed: 28
------------------------
 TOTAL tests: 9710
VIRTUAL time: 11h 18min 56s 771ms
   REAL time: 46min 11s 101ms
=======================

report.xml, report.md, failures.xml, testclr_details.tar.zst

RISC-V Release-FX-QEMU: 283257 / 284333 (99.62%)

=======================
      passed: 283257
      failed: 1069
     skipped: 38
      killed: 7
------------------------
 TOTAL tests: 284371
VIRTUAL time: 29h 21min 59s 787ms
   REAL time: 1h 10min 14s 280ms
=======================

report.xml, report.md, failures.xml, testclr_details.tar.zst

RISC-V Release-FX-VF2: 306970 / 308690 (99.44%)

=======================
      passed: 306970
      failed: 1711
     skipped: 38
      killed: 9
------------------------
 TOTAL tests: 308728
VIRTUAL time: 20h 3min 49s 614ms
   REAL time: 2h 11min 59s 657ms
=======================

report.xml, report.md, failures.xml, testclr_details.tar.zst

Build information and commands

GIT: 8ea148b1871df4cda92a3dcf77fa4e1d63e6508f
CI: 8d15504ae1358a01693a7c50a10ed6536bf11989
REPO: dotnet/runtime
BRANCH: main
CONFIG: Release
LIB_CONFIG: Release

sirntar · 2025-06-04T13:15:49Z

@jkotas could you please review?

simplify genZeroInitFrameUsingBlockInit

988e2bb

dotnet-policy-service bot added the community-contribution label May 27, 2025

github-actions bot added the area-CodeGen-coreclr label May 27, 2025

sirntar added 2 commits May 27, 2025 15:36

Merge branch 'main' into simplify-zeroInitFp

78f38bd

apply format.patch

52e7c3d

jkotas added the arch-riscv label May 27, 2025

build-analysis bot mentioned this pull request May 27, 2025

Test failure: baseservices/exceptions/stackoverflow/stackoverflowtester/stackoverflowtester.cmd #110173

Open

clamp03 assigned sirntar May 28, 2025

Merge branch 'main' into simplify-zeroInitFp

c992ec0

sirntar added 2 commits June 2, 2025 08:43

fix type mismatch

e9d34a7

Merge 'main' into simplify-zeroInitFp

54a6a3d

tomeksowi reviewed Jun 2, 2025

View reviewed changes

src/coreclr/jit/codegenriscv64.cpp Outdated Show resolved Hide resolved

sirntar added 2 commits June 2, 2025 15:58

apply review suggestions

28c7311

Merge remote-tracking branch 'upstream/main' into simplify-zeroInitFp

f4e089d

Merge remote-tracking branch 'upstream/main' into simplify-zeroInitFp

e3b9c7c

build-analysis bot mentioned this pull request Jun 3, 2025

The Operation will be canceled. The next steps may not contain expected logs. dotnet/dnceng#3008

Open

3 tasks

tomeksowi approved these changes Jun 3, 2025

View reviewed changes

Merge remote-tracking branch 'upstream/main' into simplify-zeroInitFp

8ea148b

jkotas requested a review from a team June 4, 2025 14:16

jakobbotsch approved these changes Jun 5, 2025

View reviewed changes

jakobbotsch merged commit 937742e into dotnet:main Jun 5, 2025
109 checks passed

github-actions bot locked and limited conversation to collaborators Jul 5, 2025

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

[RISC-V] Simplifying the loop generated in genZeroInitFrameUsingBlockInit #116011

[RISC-V] Simplifying the loop generated in genZeroInitFrameUsingBlockInit #116011

Uh oh!

sirntar commented May 27, 2025

Uh oh!

risc-vv commented Jun 2, 2025 •

edited

Loading

Uh oh!

risc-vv commented Jun 2, 2025 •

edited

Loading

Uh oh!

Uh oh!

risc-vv commented Jun 2, 2025 •

edited

Loading

Uh oh!

risc-vv commented Jun 3, 2025 •

edited

Loading

Uh oh!

risc-vv commented Jun 4, 2025 •

edited

Loading

Uh oh!

sirntar commented Jun 4, 2025

Uh oh!

Uh oh!

Uh oh!

[RISC-V] Simplifying the loop generated in genZeroInitFrameUsingBlockInit #116011

[RISC-V] Simplifying the loop generated in genZeroInitFrameUsingBlockInit #116011

Uh oh!

Conversation

sirntar commented May 27, 2025

Uh oh!

risc-vv commented Jun 2, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

risc-vv commented Jun 2, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

risc-vv commented Jun 2, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

risc-vv commented Jun 3, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

risc-vv commented Jun 4, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

sirntar commented Jun 4, 2025

Uh oh!

Uh oh!

Uh oh!

risc-vv commented Jun 2, 2025 •

edited

Loading

risc-vv commented Jun 2, 2025 •

edited

Loading

risc-vv commented Jun 2, 2025 •

edited

Loading

risc-vv commented Jun 3, 2025 •

edited

Loading

risc-vv commented Jun 4, 2025 •

edited

Loading