Skip to content

[release/10.0-preview5] Fix implementation of IFindReferenceTargetsCallback::FoundTrackerTarget #116018

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

github-actions[bot]
Copy link
Contributor

@github-actions github-actions bot commented May 27, 2025

Backport of #115921 to release/10.0-preview5

/cc @jkoritzinsky

Customer Impact

  • Customer reported
  • Found internally

[Select one or both of the boxes. Describe how this issue impacts customers, citing the expected and actual behaviors and scope of the issue. If customer-reported, provide the issue number.]

User can experience crashes on navigations in MAUI apps on Windows. WinUI 3 apps can crash on navigation.

Regression

  • Yes
  • No

[If yes, specify when the regression was introduced. Provide the PR or commit if known.]

.NET 10 Preview 4 #113907

Testing

[How was the fix verified? How was the issue missed previously? What tests were added?]

Manual validation with the provided test app from the appcompat team.

Risk

[High/Medium/Low. Justify the indication by mentioning how risks were measured and addressed.]

Low, fix was confirmed to match previous implementation of the function with the bug.

IMPORTANT: If this backport is for a servicing release, please verify that:

  • The PR target branch is release/X.0-staging, not release/X.0.

Package authoring no longer needed in .NET 9

IMPORTANT: Starting with .NET 9, you no longer need to edit a NuGet package's csproj to enable building and bump the version.
Keep in mind that we still need package authoring in .NET 8 and older versions.

Copy link
Contributor

Tagging subscribers to this area: @dotnet/interop-contrib
See info in area-owners.md if you want to be subscribed.

Copy link
Member

@jeffschwMSFT jeffschwMSFT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm. we will take for consideration in 10 p5

@jeffschwMSFT jeffschwMSFT added the Servicing-consider Issue for next servicing release review label May 27, 2025
@jeffschwMSFT jeffschwMSFT added this to the 10.0.0 milestone May 27, 2025
@jeffschwMSFT jeffschwMSFT added Servicing-approved Approved for servicing release and removed Servicing-consider Issue for next servicing release review labels May 27, 2025
@github-actions github-actions bot force-pushed the backport/pr-115921-to-release/10.0-preview5 branch from 5e60b96 to 038f0a5 Compare May 27, 2025 19:11
@jkoritzinsky jkoritzinsky added Servicing-approved Approved for servicing release and removed Servicing-approved Approved for servicing release labels May 27, 2025
@jkoritzinsky
Copy link
Member

/ba-g "Android tests timeout"

@jkoritzinsky jkoritzinsky enabled auto-merge (squash) May 27, 2025 21:16
@jkoritzinsky jkoritzinsky disabled auto-merge May 27, 2025 21:16
@jkoritzinsky jkoritzinsky merged commit dc8fe75 into release/10.0-preview5 May 27, 2025
95 of 98 checks passed
@jkoritzinsky jkoritzinsky deleted the backport/pr-115921-to-release/10.0-preview5 branch May 27, 2025 21:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants