Skip to content

Revert [debugger] Fix crash during Async Break when APC and CET are enabled #116025

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

tommcdon
Copy link
Member

@tommcdon tommcdon commented May 27, 2025

Customer Impact

  • Customer reported
  • Found internally

This change reverts #111408 which has resulted in multiple reports of customer hangs in the debugger on .NET 10 Preview 4

Regression

  • Yes (.NET 10 Preview 3)
  • No

Testing

Manually tested.

Risk

Low risk, we are reverting a change that has caused a debugger hang

Copy link
Contributor

Tagging subscribers to this area: @tommcdon
See info in area-owners.md if you want to be subscribed.

@jeffschwMSFT jeffschwMSFT added the Servicing-approved Approved for servicing release label May 27, 2025
@jeffschwMSFT jeffschwMSFT added this to the 10.0.0 milestone May 27, 2025
Copy link
Member

@jeffschwMSFT jeffschwMSFT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm. we took for consideration in 10 preview 5

Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot encountered an error and was unable to review this pull request. You can try again by re-requesting a review.

@steveisok steveisok enabled auto-merge (squash) May 27, 2025 17:53
@steveisok steveisok disabled auto-merge May 27, 2025 19:43
@steveisok
Copy link
Member

The android leg isn't processing any work items. I would just merge this given all the others are done.

@mmitche
Copy link
Member

mmitche commented May 27, 2025

/ba green

@mmitche mmitche merged commit 5d90f93 into dotnet:release/10.0-preview5 May 27, 2025
97 of 101 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Jun 27, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants