-
Notifications
You must be signed in to change notification settings - Fork 5.1k
Delete non-existing pal tests from list #116048
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
We can |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@am11 My assumption is that you ran and built the PAL test project after this. If so, LGTM.
Yes, I ran it locally. We should run |
Should a CI configuration be added for this? Or would this become unnecessary soon when we are refactoring out pal? |
I think adding a trigger is a good idea. If/when we complete phase out coreclr-PAL, we can delete that too. As it stands, coreclr-PAL continued to be the first component during the new platform port work, and these tests help in setting the foundationary expectations straight. |
eng/pipelines/coreclr/ci.yml
Outdated
@@ -43,6 +51,7 @@ extends: | |||
# Debug builds | |||
# | |||
- template: /eng/pipelines/common/platform-matrix.yml | |||
condition: ne(variables['Build.Reason'], 'PullRequest') |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we keep this simple and just trigger the whole outer loop when changing the PAL tests?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I can remove these condition, but currently it is not triggering in this PR. Perhaps @jkoritzinsky knows if it needs something more.
/azp run runtime-coreclr outerloop |
Azure Pipelines successfully started running 1 pipeline(s). |
/ba-g known AZL infra break |
No description provided.