Skip to content

Conversation

am11
Copy link
Member

@am11 am11 commented May 27, 2025

No description provided.

@dotnet-policy-service dotnet-policy-service bot added the community-contribution Indicates that the PR has been added by a community member label May 27, 2025
@jkotas jkotas requested a review from AaronRobinsonMSFT May 27, 2025 22:42
@am11 am11 force-pushed the feature/pal-tests2 branch from ae38b7d to 763fd07 Compare May 27, 2025 22:58
@am11
Copy link
Member Author

am11 commented May 27, 2025

We can /azp run runtime-coreclr outerloop here.

@am11 am11 requested a review from jkoritzinsky May 27, 2025 23:26
Copy link
Member

@AaronRobinsonMSFT AaronRobinsonMSFT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@am11 My assumption is that you ran and built the PAL test project after this. If so, LGTM.

@am11
Copy link
Member Author

am11 commented May 27, 2025

Yes, I ran it locally. We should run /azp run runtime-coreclr outerloop as a practice on PR touching src/coreclr/pal/tests because most of the times when we don't run the PAL tests, we have to make a follow up PR (e.g. this PR is follow up of #115986 because now tests are failing in CI).

@huoyaoyuan
Copy link
Member

Should a CI configuration be added for this? Or would this become unnecessary soon when we are refactoring out pal?

@am11
Copy link
Member Author

am11 commented May 28, 2025

Should a CI configuration be added for this? Or would this become unnecessary soon when we are refactoring out pal?

I think adding a trigger is a good idea. If/when we complete phase out coreclr-PAL, we can delete that too. As it stands, coreclr-PAL continued to be the first component during the new platform port work, and these tests help in setting the foundationary expectations straight.

@@ -43,6 +51,7 @@ extends:
# Debug builds
#
- template: /eng/pipelines/common/platform-matrix.yml
condition: ne(variables['Build.Reason'], 'PullRequest')
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we keep this simple and just trigger the whole outer loop when changing the PAL tests?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can remove these condition, but currently it is not triggering in this PR. Perhaps @jkoritzinsky knows if it needs something more.

@jkotas
Copy link
Member

jkotas commented May 28, 2025

/azp run runtime-coreclr outerloop

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@jkotas
Copy link
Member

jkotas commented May 28, 2025

/ba-g known AZL infra break

@jkotas jkotas merged commit 5b5de26 into dotnet:main May 28, 2025
62 of 115 checks passed
@am11 am11 deleted the feature/pal-tests2 branch May 29, 2025 03:07
@github-actions github-actions bot locked and limited conversation to collaborators Jun 28, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area-PAL-coreclr community-contribution Indicates that the PR has been added by a community member
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants