Skip to content

[Android] Enable library smoke tests on CoreCLR Android #116091

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

kotlarmilos
Copy link
Member

@kotlarmilos kotlarmilos commented May 29, 2025

Description

Contributes to #115955

@Copilot Copilot AI review requested due to automatic review settings May 29, 2025 11:43
@kotlarmilos kotlarmilos self-assigned this May 29, 2025
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR enables the library smoke tests on CoreCLR Android by reactivating the previously commented postBuildSteps.

  • Uncomment postBuildSteps to run tests using the helix.yml template
  • Activate the conditional execution for these steps based on relevant variables

@github-actions github-actions bot added the needs-area-label An area label is needed to ensure this gets routed to the appropriate area owners label May 29, 2025
@kotlarmilos kotlarmilos added area-Infrastructure-coreclr os-android and removed needs-area-label An area label is needed to ensure this gets routed to the appropriate area owners labels May 29, 2025
@kotlarmilos kotlarmilos added this to the 10.0.0 milestone May 29, 2025
@kotlarmilos kotlarmilos requested a review from steveisok May 29, 2025 11:44
Copy link
Contributor

Tagging subscribers to this area: @hoyosjs
See info in area-owners.md if you want to be subscribed.

@kotlarmilos
Copy link
Member Author

The android-x64 coreclr job took 57min.

@kotlarmilos kotlarmilos requested a review from jkotas June 4, 2025 13:16
@jkotas
Copy link
Member

jkotas commented Jun 4, 2025

The android-x64 coreclr job took 57min.

The long times and timeouts only showed up once android-x64 coreclr job started running on most PRs. Do you believe that we have addressed the underlying eng infrastructure issue?

If you are not sure, we can try to enable this again and monitor it.

@steveisok
Copy link
Member

The android-x64 coreclr job took 57min.

The long times and timeouts only showed up once android-x64 coreclr job started running on most PRs. Do you believe that we have addressed the underlying eng infrastructure issue?

If you are not sure, we can try to enable this again and monitor it.

I'm for enabling and monitoring. The problem before was that no machines were running to service work items. It is a bit perplexing that the send to helix step took 20+ min and the 3 work items that were executed took 1-2 min each (all on different machines).

@kotlarmilos kotlarmilos merged commit c26d6a1 into dotnet:main Jun 4, 2025
155 checks passed
@kotlarmilos
Copy link
Member Author

Yes, let's monitor this. I haven’t closed the tracking issue yet. I’ll start sampling and reporting job times, and if there are no timeouts by the end of the week, I’ll close it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

3 participants