remove dead resources from mscorrc.rc #116121
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR removes dead resource definitions from the project.
- Removed unused resource string macros from src/coreclr/dlls/mscorrc/resource.h.
- Removed corresponding resource string entries from src/coreclr/dlls/mscorrc/mscorrc.rc.
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| src/coreclr/dlls/mscorrc/resource.h | Removed several dead resource macro definitions. |
| src/coreclr/dlls/mscorrc/mscorrc.rc | Removed corresponding dead resource string definitions. |
github-actions
bot
added
the
needs-area-label
jkotas
reviewed
May 30, 2025
jkotas
reviewed
May 30, 2025
jkotas
reviewed
May 30, 2025
jkotas
reviewed
May 30, 2025
jkotas
reviewed
May 30, 2025
jkotas
reviewed
May 30, 2025
jkotas
reviewed
May 30, 2025
|
@jkotas just to check, you resolved all your feedback? |
danmoseley
added
area-VM-coreclr
and removed
needs-area-label
|
Tagging subscribers to this area: @mangod9 |
Yep |
Open
3 tasks
|
/ba-g infrastructure timeouts |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.