Enable ConsoleMandel test #116157
Open
Enable ConsoleMandel test #116157
+2
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@dotnet/jit-contrib |
There was a problem hiding this comment.
Pull Request Overview
This PR enables the ConsoleMandel test by adjusting the test entry point to pass explicit command-line arguments that trigger benchmarking mode.
- Updated TestEntryPoint to use a non-empty string array.
- Passes the "-BENCH" flag with a parameter to initiate benchmarking.
| @@ -67,7 +67,8 @@ private static void PrintUsage() | |||
| [Fact] | |||
| public static int TestEntryPoint() | |||
| { | |||
| return Test(Array.Empty<string>()); | |||
| string[] testArgs = new string[] { "-BENCH", "1" }; | |||
There was a problem hiding this comment.
Consider adding a comment to explain the purpose and impact of the '-BENCH' flag so that maintainers can understand why these arguments are being passed.
Copilot uses AI. Check for mistakes.
github-actions
bot
added
the
area-CodeGen-coreclr
|
Tagging subscribers to this area: @JulieLeeMSFT, @jakobbotsch |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It takes around 10 seconds to complete, but might be worth enabling it.
Fixes: #90276