Track required properties with ValueBitArray

[PranavSenthilnathan]

No description provided.

[dotnet-policy-service]

Tagging subscribers to this area: @dotnet/area-system-text-json, @gregsdennis
See info in area-owners.md if you want to be subscribed.

[PranavSenthilnathan]

@EgorBot -arm -amd

using System.Text.Json;
using System.Text.Json.Serialization;
using BenchmarkDotNet.Attributes;
using BenchmarkDotNet.Running;

BenchmarkSwitcher.FromAssembly(typeof(RequiredJson).Assembly).Run(args);

public class RequiredJson
{
    private string? json;

    [GlobalSetup]
    public void Setup()
    {
        json = "{ \"Foo\": \"qux\", \"Bar\": \"qux\" }";
    }

    [Benchmark]
    public ClassWithRequired DeserializeClassWithRequired() =>
        JsonSerializer.Deserialize<ClassWithRequired>(json!)!;

    [Benchmark]
    public ClassWithoutRequired DeserializeClassWithoutRequired() =>
        JsonSerializer.Deserialize<ClassWithoutRequired>(json!)!;

    public class ClassWithRequired
    {
        [JsonRequired]
        public string? Foo { get; set; }
        public string? Bar { get; set; }
        public string? Baz { get; set; }
    }

    public class ClassWithoutRequired
    {
        public string? Foo { get; set; }
        public string? Bar { get; set; }
        public string? Baz { get; set; }
    }
}

[eiriktsarpalis]

Is there a way to command EgorBot to also include allocations? cc @EgorBo

[PranavSenthilnathan]

@EgorBot -amd

using System.Text.Json;
using System.Text.Json.Serialization;
using BenchmarkDotNet.Attributes;
using BenchmarkDotNet.Running;

BenchmarkSwitcher.FromAssembly(typeof(RequiredJson).Assembly).Run(args);

[MemoryDiagnoser]
public class RequiredJson
{
    private string? json;

    [GlobalSetup]
    public void Setup()
    {
        json = "{ \"Foo\": \"qux\", \"Bar\": \"qux\" }";
    }

    [Benchmark]
    public ClassWithRequired DeserializeClassWithRequired() =>
        JsonSerializer.Deserialize<ClassWithRequired>(json!)!;

    [Benchmark]
    public ClassWithoutRequired DeserializeClassWithoutRequired() =>
        JsonSerializer.Deserialize<ClassWithoutRequired>(json!)!;

    public class ClassWithRequired
    {
        [JsonRequired]
        public string? Foo { get; set; }
        public string? Bar { get; set; }
        public string? Baz { get; set; }
    }

    public class ClassWithoutRequired
    {
        public string? Foo { get; set; }
        public string? Bar { get; set; }
        public string? Baz { get; set; }
    }
}

[PranavSenthilnathan]

This is what I get locally:

BenchmarkDotNet v0.14.1-nightly.20250107.205, Windows 11 (10.0.26100.4061)
AMD Ryzen 9 9950X 4.30GHz, 1 CPU, 32 logical and 16 physical cores
.NET SDK 10.0.100-preview.3.25201.16
  [Host]     : .NET 10.0.0 (10.0.25.17105), X64 RyuJIT AVX-512F+CD+BW+DQ+VL+VBMI
  Job-PTIRIP : .NET 10.0.0 (42.42.42.42424), X64 RyuJIT AVX-512F+CD+BW+DQ+VL+VBMI
  Job-AHYCXR : .NET 10.0.0 (42.42.42.42424), X64 RyuJIT AVX-512F+CD+BW+DQ+VL+VBMI

PowerPlanMode=00000000-0000-0000-0000-000000000000  IterationTime=250ms  MaxIterationCount=20  
MinIterationCount=15  WarmupCount=1  

Method	Toolchain	Mean	Error	StdDev	Median	Min	Max	Ratio	Gen0	Allocated	Alloc Ratio
DeserializeClassWithRequired	main	114.6 ns	1.18 ns	1.11 ns	114.6 ns	112.5 ns	116.1 ns	1.06	0.0100	168 B	1.62
DeserializeClassWithRequired	PR	108.2 ns	0.58 ns	0.48 ns	108.2 ns	107.4 ns	108.8 ns	1.00	0.0060	104 B	1.00
DeserializeClassWithoutRequired	main	107.7 ns	0.44 ns	0.41 ns	107.6 ns	107.0 ns	108.5 ns	1.01	0.0060	104 B	1.00
DeserializeClassWithoutRequired	PR	106.9 ns	0.99 ns	0.83 ns	106.8 ns	106.0 ns	108.9 ns	1.00	0.0061	104 B	1.00

[stephentoub]

BitVector32?

[dotnet-policy-service]

Draft Pull Request was automatically closed for 30 days of inactivity. Please let us know if you'd like to reopen it.