Remove redundant unsafe context #116187
Merged
Remove redundant unsafe context #116187
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
needs-area-label
EgorBo
added
reduce-unsafe
and removed
needs-area-label
|
Is this basically "if the code continues to compile after removing |
I was using R#'s 'remove redundant unsafe' inspection and the repo compiled locally |
am11
reviewed
Jun 1, 2025
...braries/System.Reflection.Metadata/src/System/Reflection/Internal/Utilities/BlobUtilities.cs
Show resolved
Hide resolved
am11
reviewed
Jun 1, 2025
...e.InteropServices.JavaScript/src/System/Runtime/InteropServices/JavaScript/JSProxyContext.cs
Show resolved
Hide resolved
|
Tagging subscribers to this area: @dotnet/area-meta |
jkotas
reviewed
Jun 1, 2025
src/libraries/System.Net.Quic/src/System/Net/Quic/Interop/msquic_generated_linux.cs
Outdated
Show resolved
Hide resolved
EgorBo
force-pushed
the
remove-redundant-unsafe-3
branch
from
0d213e0 to
c882701
Compare
This was referenced Jun 1, 2025
Open
stephentoub
approved these changes
Jun 2, 2025
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removed in a semi-automated way, some places might require it back once "unsafe callers" is implemented (although, mostly as inner unsafe scopes, not modifiers).