Skip to content

x86: Promote varargs when enumerating funclet #116228

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 4, 2025
Merged

Conversation

filipnavara
Copy link
Member

@filipnavara filipnavara commented Jun 2, 2025

The stack walker skips parent frame of a funclet for GC reporting and expects the funclet to report all variables.

Fixes #116211

@dotnet-policy-service dotnet-policy-service bot added the community-contribution Indicates that the PR has been added by a community member label Jun 2, 2025
@github-actions github-actions bot added the needs-area-label An area label is needed to ensure this gets routed to the appropriate area owners label Jun 2, 2025
@filipnavara filipnavara added arch-x86 os-windows area-VM-coreclr and removed needs-area-label An area label is needed to ensure this gets routed to the appropriate area owners labels Jun 2, 2025
Copy link
Contributor

Tagging subscribers to this area: @mangod9
See info in area-owners.md if you want to be subscribed.

@filipnavara
Copy link
Member Author

Can I get /azp run runtime-coreclr gcstress0x3-gcstress0xc here?

@MichalStrehovsky
Copy link
Member

/azp run runtime-coreclr gcstress0x3-gcstress0xc

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@filipnavara filipnavara marked this pull request as ready for review June 3, 2025 06:54
Copy link
Member

@janvorli janvorli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you!

@jkotas
Copy link
Member

jkotas commented Jun 4, 2025

/ba-g timeouts

@jkotas jkotas merged commit c3a914f into dotnet:main Jun 4, 2025
115 of 119 checks passed
@filipnavara filipnavara deleted the patch-21 branch June 5, 2025 06:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
arch-x86 area-VM-coreclr community-contribution Indicates that the PR has been added by a community member os-windows
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Assert failure !CREATE_CHECK_STRING(pMT && pMT->Validate()) during PInvokeTests.VarargsTest.TestEntryPoint on win-x86
4 participants