Enable exceptions on wrong LDELEM arguments #116235
Merged
+4
−4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When the array is null, throw NullReferenceException When the index is out of range, throw IndexOutOfRangeException Until now, it was asserting instead.
There was a problem hiding this comment.
Pull Request Overview
This PR enables exceptions on wrong LDELEM arguments by replacing assertion failures with explicit exception throwing.
- Replaces assert(0) with COMPlusThrow(kNullReferenceException) for null array references.
- Replaces assert(0) with COMPlusThrow(kIndexOutOfRangeException) for out-of-range index values.
github-actions
bot
added
the
needs-area-label
kg
approved these changes
Jun 3, 2025
|
|
Thank you for spotting this! I was just fixing random small issues I've hit in the coreclr codegen bringup tests, so I have missed it. Let me change that too. |
filipnavara
approved these changes
Jun 3, 2025
Open
3 tasks
|
/ba-g timeout of build of an unrelated NativeAOT leg. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When the array is null, throw NullReferenceException When the index is out of range, throw IndexOutOfRangeException
Until now, it was asserting instead.