JIT: Remove old loop metrics #116267
Merged
JIT: Remove old loop metrics #116267
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
area-CodeGen-coreclr
There was a problem hiding this comment.
Pull Request Overview
This PR removes all references and associated code for the obsolete loop metrics functionality (COUNT_LOOPS) from the JIT components.
- Removed COUNT_LOOPS macro conditions from preprocessor directives in multiple source files
- Cleared obsolete declarations and metrics printing code related to loop statistics
Reviewed Changes
Copilot reviewed 7 out of 7 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| src/coreclr/jit/utils.cpp | Removed COUNT_LOOPS from the preprocessor conditions. |
| src/coreclr/jit/jit.h | Deleted the COUNT_LOOPS macro definition. |
| src/coreclr/jit/gentree.h | Updated preprocessor conditions to eliminate COUNT_LOOPS. |
| src/coreclr/jit/gentree.cpp | Removed COUNT_LOOPS from conditional compilation directives. |
| src/coreclr/jit/compiler.hpp | Adjusted macro conditions by removing COUNT_LOOPS. |
| src/coreclr/jit/compiler.h | Deleted obsolete declarations and comments for loop metrics. |
| src/coreclr/jit/compiler.cpp | Cleared code and output related to COUNT_LOOPS metrics printing. |
|
Tagging subscribers to this area: @JulieLeeMSFT, @jakobbotsch |
jakobbotsch
approved these changes
Jun 3, 2025
|
/ba-g failures unrelated |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removes the
COUNT_LOOPSmacro, and everything defined under it.@jakobbotsch PTAL, thanks!