Fix bash array expansion #116321
Merged
Fix bash array expansion #116321
+2
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Follow-up to dotnet#116315 (comment)
|
Tagging subscribers to this area: @dotnet/runtime-infrastructure |
There was a problem hiding this comment.
Pull Request Overview
This PR updates the Bash arguments array handling to avoid introducing an empty string element and ensures proper expansion when the array is empty.
- Initialize
argumentsas an empty array instead of containing a lone empty string - Use a parameter expansion trick to safely append existing arguments only when present
| @@ -549,7 +549,7 @@ while [[ $# > 0 ]]; do | |||
| done | |||
|
|
|||
| if [ ${#actInt[@]} -eq 0 ]; then | |||
| arguments=("-restore" "-build" "${arguments[@]}") | |||
| arguments=("-restore" "-build" ${arguments[@]+"${arguments[@]}"}) | |||
There was a problem hiding this comment.
[nitpick] The ${arguments[@]+"${arguments[@]}"} expansion is more complex than needed in Bash; using a quoted "${arguments[@]}" will safely expand existing elements and gracefully handle empty arrays.
Suggested change
| arguments=("-restore" "-build" ${arguments[@]+"${arguments[@]}"}) | |
| arguments=("-restore" "-build" "${arguments[@]}") |
Copilot uses AI. Check for mistakes.
There was a problem hiding this comment.
No, it doesn't with the version of bash on macOS.
jkoritzinsky
approved these changes
Jun 4, 2025
ViktorHofer
approved these changes
Jun 4, 2025
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow-up to #116315 (comment)
/cc @omajid