Skip to content

Correct sequence point comment #116366

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 6, 2025
Merged

Correct sequence point comment #116366

merged 1 commit into from
Jun 6, 2025

Conversation

noahfalk
Copy link
Member

@noahfalk noahfalk commented Jun 6, 2025

The sequence points fall after the CALL instructions, not before. Fixing the misleading code comment.

@Copilot Copilot AI review requested due to automatic review settings June 6, 2025 09:14
@github-actions github-actions bot added the needs-area-label An area label is needed to ensure this gets routed to the appropriate area owners label Jun 6, 2025
Copilot
Copilot AI reviewed Jun 6, 2025
View reviewed changes
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

Fixes a misleading comment for the CALL_SITE_BOUNDARIES flag to accurately describe when sequence points occur.

  • Updated the inline comment for CALL_SITE_BOUNDARIES to state that boundaries occur after call instructions.

@noahfalk noahfalk enabled auto-merge (squash) June 6, 2025 09:14
@noahfalk
Copy link
Member Author

noahfalk commented Jun 6, 2025

thanks to @hoyosjs who did the quick test and confirmed the actual behavior is 'after', not before

@noahfalk noahfalk merged commit e84d599 into main Jun 6, 2025
97 checks passed
@jkotas jkotas deleted the noahfalk-patch-1 branch June 8, 2025 12:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

Copilot code review Copilot Copilot left review comments

@hoyosjs hoyosjs hoyosjs approved these changes

Assignees

@noahfalk noahfalk

Labels
needs-area-label An area label is needed to ensure this gets routed to the appropriate area owners
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@noahfalk @hoyosjs