Normalize TYP_STRUCT to TYP_SIMD in impInlineUnboxNullable #116372
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
area-CodeGen-coreclr
|
Tagging subscribers to this area: @JulieLeeMSFT, @jakobbotsch |
jakobbotsch
reviewed
Jun 6, 2025
src/coreclr/jit/importer.cpp
Outdated
| CORINFO_CLASS_HANDLE valueStructCls = NO_CLASS_HANDLE; | ||
| ClassLayout* layout = nullptr; | ||
| var_types valueType = | ||
| TypeHandleToVarType(info.compCompHnd->getFieldType(valueFldHnd, &valueStructCls), valueStructCls, &layout); |
There was a problem hiding this comment.
The evaluation order of args is implementation defined in C++. That might be the reason for the failures, since the getFieldType call needs to happen before the valueStructCls arg.
There was a problem hiding this comment.
I haven't checked the failures yet, but it does look to be the problem
There was a problem hiding this comment.
Yeah, that was it, thanks!
|
@dotnet/jit-contrib PTAL simple change, the previous code was attempting to create a |
jakobbotsch
approved these changes
Jun 6, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #116369