[mono][1/2] Add SIMD Support for s390x #116669
Open
+15
−8
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is the inital patch to support simd on s390x. on s390x we have 16 floating point registers and 32 vector registers out of which f0 - f15 overlap with v0 - v15. redefine the mirrored_mask logic for unequal masks in the register allocator.
|
cc: @uweigand , @nealef, @akoeplinger , @steveisok, @giritrivedi |
dotnet-policy-service
bot
added
the
community-contribution
saitama951
changed the title
saitama951
added a commit
to saitama951/runtime
that referenced
this pull request
Jun 18, 2025
This is a followup patch to dotnet#116669 to add vector support to s390x
saitama951
added a commit
to saitama951/runtime
that referenced
this pull request
Jun 18, 2025
This is a followup patch to dotnet#116669 to add vector support to s390x
saitama951
added a commit
to saitama951/runtime
that referenced
this pull request
Jun 18, 2025
This is a followup patch to dotnet#116669 to add vector support to s390x
saitama951
added a commit
to saitama951/runtime
that referenced
this pull request
Jun 18, 2025
This is a followup patch to dotnet#116669 to add vector support to s390x
saitama951
added a commit
to saitama951/runtime
that referenced
this pull request
Jun 18, 2025
This is a followup patch to dotnet#116669 to add vector support to s390x
uweigand
reviewed
Jun 25, 2025
| g_assert(regbank_size [MONO_REG_SIMD] == regbank_size [MONO_REG_DOUBLE]); | ||
| #endif | ||
| g_assert(regbank_callee_saved_regs [MONO_REG_SIMD] == regbank_callee_saved_regs [MONO_REG_DOUBLE]); | ||
| #endif |
There was a problem hiding this comment.
Given that the regalloc code has now been changed to accept a SIMD regbank that is a superset of the FP regbank (without arch checks), maybe these assert should also be changed to accept that case in general (without arch checks). Something like
g_assert((regbank_callee_regs [MONO_REG_SIMD] & regbank_callee_regs[MONO_REG_DOUBLE])
== regbank_callee_regs [MONO_REG_DOUBLE]);
g_assert(regbank_size [MONO_REG_SIMD] >= regbank_size [MONO_REG_DOUBLE]);
(and of course update the comment above).
| #define MONO_MAX_XREGS 31 | ||
| #define MONO_ARCH_CALLEE_XREGS 0xFFFEFFFE | ||
| #define MONO_ARCH_CALLEE_XREGS 0x0 |
There was a problem hiding this comment.
The old definition should be removed, or else the new won't take effect?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the inital patch to support simd on s390x. on s390x we have 16 floating point registers and 32 vector registers out of which f0 - f15 overlap with v0 - v15.
redefine the mirrored_mask logic for unequal masks in the register allocator.