Fix the compiler toolset override for runtime-async #116722
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
needs-area-label
There was a problem hiding this comment.
Pull Request Overview
This PR ensures that the tests build uses a private compiler build supporting runtime-async by specifying both the compiler version and type.
- Adds the
RoslynCompilerTypeproperty set toCustomalongside the existing toolset version override. - Ensures the build uses a custom Roslyn compiler for async support in tests.
Comments suppressed due to low confidence (1)
src/tests/Directory.Build.props:14
- [nitpick] Consider adding a brief comment above this property to explain why
RoslynCompilerTypeneeds to be set toCustom, which will aid future maintainers in understanding its purpose.
<RoslynCompilerType>Custom</RoslynCompilerType>
|
@jakobbotsch This should fix the issue you were seeing with the toolset compiler |
am11
added
area-Infrastructure-coreclr
runtime-async
and removed
needs-area-label
|
Tagging subscribers to this area: @hoyosjs |
jakobbotsch
approved these changes
Jun 17, 2025
|
/ba-g unrelated failure |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The compiler toolset branch we're using is lagging and doesn't have this property set. I'll manually set it here.