Add ModuleBaseAddress to ETW manifest #116744
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Project N has been generating this for ages. I don't know if anything is broken if it's not in the manifest but at minimum it eliminates the risk that we'd unknowingly reuse this bit.
github-actions
bot
added
the
needs-area-label
There was a problem hiding this comment.
Pull Request Overview
Adds a new ModuleBaseAddress flag to the ETW manifest so that the RuntimePublisher.TypeFlags bitfield can emit module base addresses in events.
- Introduces
<map value="0x10" message="$(string.RuntimePublisher.TypeFlags.ModuleBaseAddress)"/>to the TypeFlags map. - Adds the corresponding
<string id="RuntimePublisher.TypeFlags.ModuleBaseAddress" value="ModuleBaseAddress"/>entry.
Comments suppressed due to low confidence (2)
src/coreclr/vm/ClrEtwAll.man:675
- Please verify that the native RuntimePublisher.TypeFlags enum (in the runtime source) has been updated to include a
ModuleBaseAddress = 0x10member so the manifest mapping matches the code.
<map value="0x10" message="$(string.RuntimePublisher.TypeFlags.ModuleBaseAddress)"/>
jkotas
approved these changes
Jun 17, 2025
brianrob
approved these changes
Jun 17, 2025
noahfalk
approved these changes
Jun 17, 2025
|
/ba-g hostactivation test failure is likely #116520 and unrelated |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Project N has been generating this for ages. I don't know if anything is broken if it's not in the manifest but at minimum it eliminates the risk that we'd unknowingly reuse this bit.
Cc @dotnet/ilc-contrib