[WIP] Apx requirements for VM and GC stubs #116806
Draft
+281
−38
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dotnet-policy-service
bot
added
the
community-contribution
|
Tagging subscribers to this area: @mangod9 |
This was referenced Jun 19, 2025
jkotas
reviewed
Jun 20, 2025
src/coreclr/inc/regdisp.h
Outdated
| PDWORD64 R29; | ||
| PDWORD64 R30; | ||
| PDWORD64 R31; | ||
| //X18 is reserved by OS, in userspace it represents TEB |
There was a problem hiding this comment.
Suggested change
| //X18 is reserved by OS, in userspace it represents TEB |
This was referenced Jun 20, 2025
jkotas
reviewed
Jun 26, 2025
| DWORD64 R29; | ||
| DWORD64 R30; | ||
| DWORD64 R31; | ||
| struct |
There was a problem hiding this comment.
@dotnet/dotnet-diag I believe CONTEXT structure is used by the debugger interfaces. Is this modification going to break them?
There was a problem hiding this comment.
I cannot say for sure at the moment. It depends on the decision if we want the debugger to track these new EGPRs. Once the context structure gets finalized is when we can say with surety about what might get impacted. Thoughts?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
DO NOT REVIEW RIGHT NOW
Addresses - #112587