-
Notifications
You must be signed in to change notification settings - Fork 5.1k
[tests][exceptions] Abbreviate long native test path #116841
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[tests][exceptions] Abbreviate long native test path #116841
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR shortens native test paths by renaming CMake projects, native libraries, DllImport references, and corresponding C# classes to more concise names under the UnhandledExceptionHandler
tests.
- Rename
foreignunhandled
→unhandlednative
for the generic unhandled test - Remove old
PInvokeRevPInvokeUnhandled
andForeignThreadRevPInvokeUnhandled
tests, replacing them withPInvokeUnhandled
andForeignUnhandled
variants - Update CMakeLists,
.csproj
, and C# sources to reflect the new native library and class names
Reviewed Changes
Copilot reviewed 10 out of 13 changed files in this pull request and generated no comments.
Show a summary per file
File | Description |
---|---|
src/tests/baseservices/exceptions/unhandled/unhandled.cs | DllImport and native library name updated |
src/tests/baseservices/exceptions/unhandled/CMakeLists.txt | CMake project and target renamed |
src/tests/baseservices/exceptions/UnhandledExceptionHandler/PInvokeRevPInvokeUnhandled | Removed obsolete CMakeLists |
src/tests/baseservices/exceptions/UnhandledExceptionHandler/PInvoke/PInvokeUnhandled.csproj | Update source file reference in project |
src/tests/baseservices/exceptions/UnhandledExceptionHandler/PInvoke/PInvokeUnhandled.cs | Rename class, DllImport, and static constructor |
src/tests/baseservices/exceptions/UnhandledExceptionHandler/PInvoke/CMakeLists.txt | New CMakeLists for PInvokeUnhandledNative |
src/tests/baseservices/exceptions/UnhandledExceptionHandler/ForeignThreadRevPInvokeUnhandled | Removed obsolete CMakeLists |
src/tests/baseservices/exceptions/UnhandledExceptionHandler/Foreign/ForeignUnhandled.csproj | Update source file reference in project |
src/tests/baseservices/exceptions/UnhandledExceptionHandler/Foreign/ForeignUnhandled.cs | Rename class, DllImport, and static constructor |
src/tests/baseservices/exceptions/UnhandledExceptionHandler/Foreign/CMakeLists.txt | New CMakeLists for ForeignUnhandledNative |
{ | ||
[DllImport("ForeignThreadRevPInvokeUnhandled")] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not sure how this dllimport resolved before when the file and cmake used ForeignThreadRevPInvokeUnhandledNative
I've also explored putting the two projects directly under UnhandledExceptionHandler, but I'm not familiar enough with the build/CMake to avoid having each other's native files in the test artifacts directories. |
Should partially mitigate #110407
UnhandledExceptionHandler/ForeignThreadRevPInvokeUnhandled/ForeignThreadRevPInvokeUnhandled.*
to
UnhandledExceptionHandler/Foreign/ForeignUnhandled.*
UnhandledExceptionHandler/PInvokeRevPInvokeUnhandled/PInvokeRevPInvokeUnhandled.*
to
UnhandledExceptionHandler/PInvoke/PInvokeUnhandled.*
Testing