JIT: avoid creating unnecessary temp for indirect virtual stub calls #116875
+9
−6
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We don't need to spill the stub address if it's already a local. Peeled off from dotnet#116771.
There was a problem hiding this comment.
Pull Request Overview
This PR optimizes indirect virtual stub calls by avoiding unnecessary temporary variable allocation when the stub address is already stored in a local variable.
- Eliminates temp spill for stub addresses that are local
- Updates the relevant conditional in impImportCall to check the operand type
github-actions
bot
added
the
area-CodeGen-coreclr
|
@amanasifkhalid PTAL Should save a bit of code size. |
|
Tagging subscribers to this area: @JulieLeeMSFT, @jakobbotsch |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We don't need to spill the stub address if it's already a local.
Peeled off from #116771.