Enable several recently added analyzers #116881
Merged
+39
−14
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stephentoub
requested review from
marek-safar and
MichalStrehovsky
as code owners
There was a problem hiding this comment.
Pull Request Overview
This pull request enables several recently added analyzers. It updates regex matching logic in linker XML processing files to use Regex.IsMatch, inserts logging code blocks in multiple hosting lifetime implementations, and revises analyzer settings in the global configuration.
Reviewed Changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| src/tools/illink/src/linker/Linker.Steps/ProcessLinkerXmlBase.cs | Replaces regex.Match(...).Success with regex.IsMatch for improved clarity. |
| src/libraries/Microsoft.Extensions.Hosting/src/Internal/ConsoleLifetime.cs | Wraps logging calls within a new if block in OnApplicationStarted. |
| src/libraries/Microsoft.Extensions.Hosting.WindowsServices/src/WindowsServiceLifetime.cs | Adds braces to enclose logging within the ApplicationStarted registration. |
| src/libraries/Microsoft.Extensions.Hosting.Systemd/src/SystemdLifetime.cs | Similar update to enclose logging calls within a conditional block. |
| src/coreclr/tools/Common/Compiler/ProcessLinkerXmlBase.cs | Replaces regex.Match(...).Success with regex.IsMatch for consistent behavior. |
| eng/CodeAnalysis.src.globalconfig | Updates analyzer comments and enables additional analyzers with new severities. |
github-actions
bot
added
the
needs-area-label
dotnet-policy-service
bot
added
the
linkable-framework
This was referenced Jun 21, 2025
teo-tsirpanis
added
area-Meta
and removed
linkable-framework
dotnet-policy-service
bot
added
the
linkable-framework
stephentoub
force-pushed
the
enablemoreanalyzers
branch
from
483447c to
3b73682
Compare
stephentoub
force-pushed
the
enablemoreanalyzers
branch
from
3b73682 to
bfc530b
Compare
stephentoub
removed
the
linkable-framework
dotnet-policy-service
bot
added
the
linkable-framework
stephentoub
removed
the
linkable-framework
dotnet-policy-service
bot
added
the
linkable-framework
stephentoub
force-pushed
the
enablemoreanalyzers
branch
from
bfc530b to
d10159e
Compare
stephentoub
force-pushed
the
enablemoreanalyzers
branch
from
d10159e to
9444775
Compare
stephentoub
removed
the
linkable-framework
dotnet-policy-service
bot
added
the
linkable-framework
jkotas
approved these changes
Jul 1, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.