[release/9.0-staging] Update dependencies from dotnet/xharness #116908
+10
−10
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![dotnet-maestro[bot]](https://avatars.githubusercontent.com/in/16706?s=60&v=4){kind=small}
…50617.3 Microsoft.DotNet.XHarness.CLI , Microsoft.DotNet.XHarness.TestRunners.Common , Microsoft.DotNet.XHarness.TestRunners.Xunit From Version 9.0.0-prerelease.25269.3 -> To Version 9.0.0-prerelease.25317.3
There was a problem hiding this comment.
Pull Request Overview
This PR updates the XHarness dependencies to a newer prerelease and adjusts related configurations.
- Bump XHarness CLI and test runner packages from
9.0.0-prerelease.25269.3to9.0.0-prerelease.25317.3 - Update matching SHAs in
Version.Details.xml - Add two new Emsdk package sources and remove an existing SDK feed in
NuGet.config - Update the .NET tool manifest version for XHarness CLI
Reviewed Changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| eng/Versions.props | Bumped XHarness package versions |
| eng/Version.Details.xml | Updated XHarness dependency versions and SHAs |
| NuGet.config | Added additional emsdk feeds and removed dotnet-sdk package source |
| .config/dotnet-tools.json | Updated XHarness CLI tool version |
Comments suppressed due to low confidence (1)
NuGet.config:17
- It looks like the dotnet-sdk package source was removed in this change, which may break restores for SDK packages. Please confirm if this deletion was intentional or re-add the source.
<!-- End: Package sources from dotnet-sdk -->
NuGet.config
Outdated
Comment on lines
13
to
14
| <add key="darc-pub-dotnet-emsdk-b567cdb-2" value="https://pkgs.dev.azure.com/dnceng/public/_packaging/darc-pub-dotnet-emsdk-b567cdb6-2/nuget/v3/index.json" /> | ||
| <add key="darc-pub-dotnet-emsdk-b567cdb-1" value="https://pkgs.dev.azure.com/dnceng/public/_packaging/darc-pub-dotnet-emsdk-b567cdb6-1/nuget/v3/index.json" /> |
There was a problem hiding this comment.
[nitpick] The newly added emsdk package sources -2 and -1 could be sorted (e.g., -1 then -2) to keep the list in ascending order for consistency.
Suggested change
| <add key="darc-pub-dotnet-emsdk-b567cdb-2" value="https://pkgs.dev.azure.com/dnceng/public/_packaging/darc-pub-dotnet-emsdk-b567cdb6-2/nuget/v3/index.json" /> | |
| <add key="darc-pub-dotnet-emsdk-b567cdb-1" value="https://pkgs.dev.azure.com/dnceng/public/_packaging/darc-pub-dotnet-emsdk-b567cdb6-1/nuget/v3/index.json" /> | |
| <add key="darc-pub-dotnet-emsdk-b567cdb-1" value="https://pkgs.dev.azure.com/dnceng/public/_packaging/darc-pub-dotnet-emsdk-b567cdb6-1/nuget/v3/index.json" /> | |
| <add key="darc-pub-dotnet-emsdk-b567cdb-2" value="https://pkgs.dev.azure.com/dnceng/public/_packaging/darc-pub-dotnet-emsdk-b567cdb6-2/nuget/v3/index.json" /> |
Copilot uses AI. Check for mistakes.
kotlarmilos
approved these changes
Jun 25, 2025
…07ca-a017-4d20-9f2c-f04af0372ee1
jozkee
added
Servicing-approved
…07ca-a017-4d20-9f2c-f04af0372ee1
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request updates the following dependencies
From https://github.com/dotnet/xharness