[cDAC] Support ISOSDacInterface16 #116938
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR adds support for the new ISOSDacInterface16 in the cDAC shim to prevent instantiation failures by SOS. Key changes include:
- Updating SOSDacImpl to implement ISOSDacInterface16 by adding it to the interface list, declaring a new private field (_legacyImpl16), and initializing it in the constructor.
- Implementing the GetGCDynamicAdaptationMode method in SOSDacImpl.
- Adding the ISOSDacInterface16 definition in the corresponding interface file.
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| src/native/managed/cdac/mscordaccore_universal/Legacy/SOSDacImpl.cs | Added ISOSDacInterface16 to the implemented interfaces and created the corresponding private field and method implementation. |
| src/native/managed/cdac/mscordaccore_universal/Legacy/ISOSDacInterface.cs | Added the interface definition for ISOSDacInterface16. |
|
Tagging subscribers to this area: @steveisok, @dotnet/dotnet-diag |
|
/azp run runtime-diagnostics |
|
Azure Pipelines successfully started running 1 pipeline(s). |
hoyosjs
approved these changes
Jun 23, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ISOSDacInterface16was recently added. Adds support for the cDAC shim for the new method. This was previously causing failures when SOS attempted to instantiate the cDAC.